Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs - Add the new feature table to various feature sections #9585

Merged
merged 3 commits into from
Jul 20, 2020
Merged

Docs - Add the new feature table to various feature sections #9585

merged 3 commits into from
Jul 20, 2020

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Jul 17, 2020 •
edited
Loading

Also cleaning up some creationTimestamps from yaml examples.

It'd be great if someone could double check these versions or even suggest any minimum k8s versions that I left out here.

followup to #9555

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/documentation size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 17, 2020
@rifelpet rifelpet changed the title Docs - Add the new feature table to various feature sections WIP Docs - Add the new feature table to various feature sections Jul 17, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2020
@rifelpet
Copy link
Member Author

FYI @MoShitrit I see that the table's shadow is still the full width on FireFox so the fix you provided might have only worked in Chrome

image

@moshevayner
Copy link
Member

FYI @MoShitrit I see that the table's shadow is still the full width on FireFox so the fix you provided might have only worked in Chrome

image

Huh, you're right!
Apparently, seems like it's the only browser that doesn't handle that well. I checked in Safari and Chrome and both show it properly. I wonder why is FF different.
Any idea, @mikesplain ?

@mikesplain
Copy link
Contributor

Interesting. I'll open a up a PR fix.

@mikesplain mikesplain mentioned this pull request Jul 17, 2020
Merged
@mikesplain
Copy link
Contributor

I believe this should take care of that issue: #9592

@rifelpet rifelpet force-pushed the docs-feature branch 3 times, most recently from f6eb3ed to 91d8ca2 Compare July 19, 2020 22:54
rifelpet added 2 commits July 19, 2020 18:01
@rifelpet
Add the new kops feature table to a handful of feature sections
485f95a
@rifelpet
Make feature tables that dont have a FF version more intuitive
5475875 
Originally `kops_feature_table(kops_added_default='1.17')` would generate a single column with a header of Default which isnt very intuitive. This replaces the header with Introduced which I think is more intuitive
@rifelpet rifelpet changed the title WIP Docs - Add the new feature table to various feature sections Docs - Add the new feature table to various feature sections Jul 19, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2020
@hakman
Copy link
Member

hakman commented Jul 20, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 75461d9 into kubernetes:master Jul 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 20, 2020
@rifelpet rifelpet deleted the docs-feature branch October 29, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
5 participants
@rifelpet @k8s-ci-robot @moshevayner @mikesplain @hakman