add os.RemoveAll err verification

[zhouhao3]

Signed-off-by: Zhou Hao [email protected]

[k8s-ci-robot]

Hi @zhouhao3. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gjtempleton]

/lgtm

[rifelpet]

/ok-to-test

[johngmyers]

@zhouhau3 Thank you for your PR. I appreciate efforts to improve the tests.

Unfortunately, this particular change does not bring a lot of value. The failure it is checking for neither indicates a problem in the code under test nor would it invalidate a successful test result. It adds the cost of code complexity to negligible benefit.

I would suggest that your time and the time of the reviewers would be better spent on a different class of improvement. Perhaps you could pick an issue from https://github.com/kubernetes/kops/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

[zhouhao3]

@johngmyers Okay, I will focus on these issues you mentioned in the future, thank you for your suggestion.

[justinsb]

Going to merge this one; these sorts of things can be a good way to get into the codebase - thanks @zhouhao3 and looking forward to seeing what you tackle next :-) I always find fixing problems you're encountering yourself is a good way to proceed, particularly if you're trying to do something a little different which other people might not yet have encountered.

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, zhouhao3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [justinsb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment