Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Digital Ocean] Upload binaries to DO Spaces #9672

Merged
merged 1 commit into from
Aug 6, 2020
Merged

[Digital Ocean] Upload binaries to DO Spaces #9672

merged 1 commit into from
Aug 6, 2020

Conversation

srikiz
Copy link
Contributor

@srikiz srikiz commented Aug 3, 2020

Using s3cmd to upload KOPS binaries to DO spaces, helps in development when working on nodeup and other binaries to use custom images from DO Spaces.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 3, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @srikiz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 3, 2020
@rifelpet
Copy link
Member

rifelpet commented Aug 3, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 3, 2020
@johngmyers
Copy link
Member

@srikiz Could you perhaps add this logic to hack/upload?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2020
@srikiz
Copy link
Contributor Author

srikiz commented Aug 5, 2020

@johngmyers - I have incorporated your comments. Please have a look when you get a chance, thanks !

johngmyers
johngmyers reviewed Aug 5, 2020
View reviewed changes
hack/upload Outdated
@@ -35,5 +35,11 @@ if [[ "${DEST:0:6}" == "oss://" ]]; then
exit 0
fi

if [[ "${DEST:0:5}" == "do://" ]]; then
DO_BUCKET=`echo "${DEST}" | cut -c 6-`
s3cmd put "*" ${SRC}/ s3://$DO_BUCKET --recursive --acl-public
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this use PUBLIC like the others?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have set the --acl-public flag set, allowing read access for everyone.

Copy link
Member

@johngmyers johngmyers Aug 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point is to allow callers to omit the --acl-public flag by calling hack/upload --private.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I got that now. I didn't realize parameter substitution was happening.. I updated it and squashed the commits as well.

@johngmyers
Copy link
Member

With the change to hack/upload is the Makefile change still needed? Can people not use make dev-upload?

@srikiz
Copy link
Contributor Author

srikiz commented Aug 6, 2020

yeah, make dev-upload is good. I reverted the change in Makefile. Thanks @johngmyers !

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 6, 2020
@johngmyers
Copy link
Member

Also, please squash commits.

@srikiz srikiz force-pushed the DO-upload-to-spaces branch from a00a456 to 42b1daf Compare August 6, 2020 18:40
@johngmyers
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, srikiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit b6f4307 into kubernetes:master Aug 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 6, 2020
@srikiz srikiz deleted the DO-upload-to-spaces branch November 24, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers left review comments

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@srikiz @k8s-ci-robot @rifelpet @johngmyers