Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade cluster-proportional-autoscaler to multi-arch image #9674

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Upgrade cluster-proportional-autoscaler to multi-arch image #9674

merged 1 commit into from
Aug 4, 2020

Conversation

johngmyers
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/addons approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 4, 2020
@hakman
Copy link
Member

hakman commented Aug 4, 2020

I think the nodeSelector changes from #9431 can also be reverted now.

@johngmyers johngmyers force-pushed the upgrade-cluster-p-autoscaler branch from 7e700f4 to dc222a0 Compare August 4, 2020 04:39
@johngmyers johngmyers requested a review from hakman August 4, 2020 04:46
@hakman
Copy link
Member

hakman commented Aug 4, 2020

@johngmyers Any thoughts on removing the nodeSelector for masters now?

@johngmyers
Copy link
Member Author

I'm all for it.

@hakman
Copy link
Member

hakman commented Aug 4, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7ee2a33 into kubernetes:master Aug 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 4, 2020
@johngmyers johngmyers deleted the upgrade-cluster-p-autoscaler branch August 4, 2020 05:22
@hakman hakman mentioned this pull request Aug 4, 2020
Merged
@rifelpet
Copy link
Member

rifelpet commented Aug 7, 2020 •
edited
Loading

The arm64 jobs are failing cluster validation now

https://testgrid.k8s.io/kops-misc#kops-aws-arm64-latest

E0806 19:50:21.742557 5755 remote_image.go:113] PullImage "k8s.gcr.io/cpa/cluster-proportional-autoscaler:1.8.2" from image service failed: rpc error: code = Unknown desc = no matching manifest for linux/arm64/v8 in the manifest list entries

@hakman
Copy link
Member

hakman commented Aug 7, 2020

Small issue:

sudo docker pull k8s.gcr.io/cpa/cluster-proportional-autoscaler:1.8.2 --platform arm64
1.8.2: Pulling from cpa/cluster-proportional-autoscaler
no matching manifest for linux/arm64 in the manifest list entries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@hakman hakman Awaiting requested review from hakman

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@johngmyers @k8s-ci-robot @hakman @rifelpet