Support for using hostPort when using kube-router

[andsens]

Enable portmap plugin in the kube-router cni config to support hostPort.
Similar to #7295 (flannel), #4063 (canal), and #3206 (calico).

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @andsens!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @andsens. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andsens]

/check-cla

[andsens]

/assign @johngmyers

[johngmyers]

@andsens Please fix the CLA problem. You might need to ensure your email address is associated with your GitHub account.

[andsens]

@johngmyers I am signed up, somethings buggy somewhere. We signed up as an org and my google account is connected as an employee account. It doesn't seem that my github account will connect though.
When I hit "Sign up as an employee" I get this screen:

which leads me to this screen

And the org is definitely signed up:

Any pointers?

[rifelpet]

@andsens is your github email and the author email used in the git commits associated with the org? You may need to use the helpdesk mentioned in the first bot comment above

• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/

[andsens]

/check-cla

[johngmyers]

/ok-to-test

[andsens]

@rifelpet @johngmyers, fixed. My account at LF was just an administrator and not a contributor.

[rifelpet]

The GitHub Actions and Travis failures are because you need to run make kops-gobindata. The e2e failure is just a flake.

[andsens]

@rifelpet fixed

[hakman]

@andsens a few more things:

1. Bump the version here also:
   

   kops/upup/pkg/fi/cloudup/bootstrapchannelbuilder.go

   Lines 842 to 846 in 4990b71

   	key := "networking.kuberouter"
   	versions := map[string]string{
   	"k8s-1.6": "0.3.1-kops.4",
   	"k8s-1.12": "1.0.0-kops.2",
   	}

2. Add --bgp-graceful-restart=true to the list of args, same as in here.

Thanks!

[andsens]

@hakman I don't understand what that has to do with enabling an unrelated plugin? I'd rather not take ownership of code I don't understand by showing up in git-blame.

[hakman]

The parameter is part of the hostport example. In any case, will add it with the next upgrade to 1.0.1 someday.
Can you do the version bump?

[hakman]

Hey @andsens. Just wanted to check if you are ok with the suggested change to bump the manifest version. It is required for the updates to work properly. Thanks.

kops/upup/pkg/fi/cloudup/bootstrapchannelbuilder.go

Lines 842 to 846 in 4990b71

	key := "networking.kuberouter"
	versions := map[string]string{
	"k8s-1.6": "0.3.1-kops.4",
	"k8s-1.12": "1.0.0-kops.2",
	}

[andsens]

@hakman argh, apologies. I saw your mail this morning and planned to do the bump and then immediately forgot all about it.
I will add the change tomorrow and update the PR.

[hakman]

Sound good. Thanks @andsens!

[andsens]

@hakman done. I enabled BGP graceful restart as well. Had to read up on it to figure out what it does first though, pretty neat :-)

[hakman]

Hehe. Really nice @andsens.
Feel free to open another PR for upgrading kube-router to v1.0.1, if you think that's a good idea.
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andsens, hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hakman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment