Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an initial structure for openstack cloudmock #9691

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Aug 6, 2020

More info in the docs changes.

This adds stubbed HTTP handlers for every resource type used by Kops. Currently they only return an empty 200 response but followup PRs will implement the relevant CRUD logic.

More info in the docs changes. This adds stubbed http handlers for every resource type used by Kops.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from hakman and rdrgmnzs August 6, 2020 04:15
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2020
@hakman hakman requested review from zetaab and olemarkus and removed request for rdrgmnzs August 6, 2020 06:01
@olemarkus
Copy link
Member

Approach looks good to me.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit da710a0 into kubernetes:master Aug 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 6, 2020
@rifelpet rifelpet deleted the openstack-cloudmock-part3 branch October 29, 2020 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants