Respect Topology when assigning floating ips or not #9701
Conversation
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
area/api
area/provider/openstack
olemarkus
force-pushed
the
openstack-fixed-ip-npr
branch
from
832fb51 to
99d6f3b
Compare
k8s-ci-robot
added
size/S
olemarkus
force-pushed
the
openstack-fixed-ip-npr
branch
from
99d6f3b to
e69ce0f
Compare
k8s-ci-robot
added
size/M
| ) | ||
|
|
||
| func openstackValidateCluster(c *kops.Cluster) (errList field.ErrorList) { | ||
| if c.Spec.CloudConfig.Openstack.Router != nil && c.Spec.CloudConfig.Openstack.Router.ExternalNetwork == nil { |
There was a problem hiding this comment.
But public topology doesn't require an external network when there's no router?
There was a problem hiding this comment.
Public topology means using floating IPs. In order to use floating IPs you need both an external network and you need a router (which handles traffic between internal and external network). So public topology is not possible without one.
There was a problem hiding this comment.
But this validation code skips the topology check if c.Spec.CloudConfig.Openstack.Router is nil
There was a problem hiding this comment.
Ah. That is quite a bug. Fixed now. And added some tests as well.
olemarkus
force-pushed
the
openstack-fixed-ip-npr
branch
from
e69ce0f to
6ea564b
Compare
k8s-ci-robot
added
size/L
olemarkus
force-pushed
the
openstack-fixed-ip-npr
branch
from
6ea564b to
815b284
Compare
|
/retest |
olemarkus
force-pushed
the
openstack-fixed-ip-npr
branch
from
815b284 to
fbcdeb2
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This is a commit that got lost from #9560, I think. Without this, kops will unconditionally add floating IPs even though openstack setup doesn't support it resulting in an npr.
/kind bug