-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to klog v2 #9765
Merged
Merged
Upgrade to klog v2 #9765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d895616
to
87a7af4
Compare
This splits up the kubernetes 1.19 PR to make it easier to keep up to date until we get it sorted out.
/retest |
/test pull-kops-e2e-cni-weave |
/lgtm |
/hold |
/hold cancel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/api
area/channels
area/documentation
area/kops-controller
area/nodeup
area/provider/alicloud
Issues or PRs related to alicloud provider
area/provider/aws
Issues or PRs related to aws provider
area/provider/digitalocean
Issues or PRs related to digitalocean provider
area/provider/openstack
Issues or PRs related to openstack provider
area/provider/spotinst
Issues or PRs related to spotinst provider
area/rolling-update
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits up #9565 to make it easier to keep up to date until we get it sorted out (there have been a lot of merge conflicts with that PR due to klog v2, and this update should be safe regardless of the kubernetes dependences)