Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to klog v2 #9765

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Upgrade to klog v2 #9765

merged 1 commit into from
Aug 17, 2020

Conversation

rifelpet
Copy link
Member

This splits up #9565 to make it easier to keep up to date until we get it sorted out (there have been a lot of merge conflicts with that PR due to klog v2, and this update should be safe regardless of the kubernetes dependences)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 16, 2020
@rifelpet rifelpet changed the title WIP Upgrade to klog2 WIP Upgrade to klog v2 Aug 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/channels area/kops-controller approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup area/provider/alicloud Issues or PRs related to alicloud provider area/provider/aws Issues or PRs related to aws provider area/provider/digitalocean Issues or PRs related to digitalocean provider area/provider/openstack Issues or PRs related to openstack provider area/provider/spotinst Issues or PRs related to spotinst provider area/rolling-update labels Aug 16, 2020
@rifelpet rifelpet force-pushed the klog2 branch 3 times, most recently from d895616 to 87a7af4 Compare August 16, 2020 19:26
@rifelpet rifelpet changed the title WIP Upgrade to klog v2 Upgrade to klog v2 Aug 16, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2020
This splits up the kubernetes 1.19 PR to make it easier to keep up to date until we get it sorted out.
@rifelpet
Copy link
Member Author

/retest

@rifelpet
Copy link
Member Author

/test pull-kops-e2e-cni-weave

@hakman
Copy link
Member

hakman commented Aug 17, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2020
@hakman
Copy link
Member

hakman commented Aug 17, 2020

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2020
@hakman
Copy link
Member

hakman commented Aug 17, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 56f3cb3 into kubernetes:master Aug 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/channels area/documentation area/kops-controller area/nodeup area/provider/alicloud Issues or PRs related to alicloud provider area/provider/aws Issues or PRs related to aws provider area/provider/digitalocean Issues or PRs related to digitalocean provider area/provider/openstack Issues or PRs related to openstack provider area/provider/spotinst Issues or PRs related to spotinst provider area/rolling-update cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants