Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Weave Net to v2.7.0 #9783

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Update Weave Net to v2.7.0 #9783

merged 1 commit into from
Aug 19, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Aug 19, 2020

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/addons approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 19, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 19, 2020
rifelpet
rifelpet reviewed Aug 19, 2020
View reviewed changes
upup/models/cloudup/resources/addons/networking.weave/k8s-1.12.yaml.template Outdated
@@ -253,8 +253,6 @@ spec:
operator: Exists
- effect: NoExecute
operator: Exists
- key: CriticalAddonsOnly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the removal of this toleration?

Also maybe we should add a comment at the top that links to where this manifest (loosely) came from: https://github.com/weaveworks/weave/blob/9f00f78d3b9d5a8a31fdd90ec691095028e2690a/prog/weave-kube/weave-daemonset-k8s-1.11.yaml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some confusion from me. Added back and also the header.
One other thing, had to move from the 1.8 manifest (that doesn't exist anymore) to the 1.19 one.

@hakman hakman force-pushed the weave-2.7.0 branch 3 times, most recently from 320ab62 to 183c21a Compare August 19, 2020 16:31
@hakman hakman requested a review from rifelpet August 19, 2020 16:51
@rifelpet
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit 899c43b into kubernetes:master Aug 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 19, 2020
@hakman hakman deleted the weave-2.7.0 branch August 23, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

@olemarkus olemarkus Awaiting requested review from olemarkus

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@hakman @k8s-ci-robot @rifelpet