Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.19.0-alpha.3 #9801

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Release 1.19.0-alpha.3 #9801

merged 3 commits into from
Aug 24, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Aug 23, 2020

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2020
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/addons approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 23, 2020
zetaab
zetaab approved these changes Aug 23, 2020
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2020
johngmyers
johngmyers reviewed Aug 23, 2020
View reviewed changes
@hakman hakman force-pushed the release-1.19.0-alpha.3 branch from e528779 to 92a3676 Compare August 24, 2020 02:30
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2020
@rdrgmnzs
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2020
@mikesplain
Copy link
Contributor

/lgtm

@rifelpet
Copy link
Member

/lgtm

@hakman
Copy link
Member Author

hakman commented Aug 24, 2020

Thanks everyone 👍
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2020
@hakman
Copy link
Member Author

hakman commented Aug 24, 2020

/test all

@k8s-ci-robot k8s-ci-robot merged commit 9cb6797 into kubernetes:master Aug 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 24, 2020
@hakman hakman deleted the release-1.19.0-alpha.3 branch August 24, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers left review comments

@zetaab zetaab zetaab approved these changes

@geojaz geojaz Awaiting requested review from geojaz

@justinsb justinsb Awaiting requested review from justinsb

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@mikesplain mikesplain Awaiting requested review from mikesplain

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@rdrgmnzs rdrgmnzs

@mikesplain mikesplain

@rifelpet rifelpet

@zetaab zetaab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
7 participants
@hakman @k8s-ci-robot @rdrgmnzs @mikesplain @rifelpet @johngmyers @zetaab