Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop trying to pull the Protokube image #9809

Merged
merged 1 commit into from
Aug 25, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Aug 25, 2020

Protokube is always side-loaded. It is never pushed to a Docker registry, so there is no reason to pull it.

protokubeImage:
  hash: 8f09e5b87f6df65e1579c56775f7c9c6ddac315579f367129c0ed297c46840f5
  name: protokube:1.18.0
  sources:
  - https://artifacts.k8s.io/binaries/kops/1.18.0/images/protokube.tar.gz
  - https://github.com/kubernetes/kops/releases/download/v1.18.0/images-protokube.tar.gz
  - https://kubeupv2.s3.amazonaws.com/kops/1.18.0/images/protokube.tar.gz

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 25, 2020
@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3b865ce into kubernetes:master Aug 25, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 25, 2020
@hakman hakman deleted the protokube-pull branch August 25, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants