WIP: OpenStack: possibility to detach instances from the load #9865
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| if err != nil { | ||
| return fmt.Errorf("error fetching instance list: %v", err) | ||
| } | ||
|
|
||
| instances := []servers.Server{} | ||
| for _, server := range allInstances { | ||
| val, ok := server.Metadata["k8s"] |
There was a problem hiding this comment.
Gophercloud also supports tags in ListOpts: https://pkg.go.dev/github.com/gophercloud/[email protected]/openstack/compute/v2/servers#ListOpts Can we use that at line 137 to already limit the instances?
|
@zetaab I was wondering if we could extract the bits in here related to instance naming, as this is already valuable on its own. Also, it shrinks the actual PR. |
|
@zetaab: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
closed, see #10557 |
original PR #8874
This is under construction. The idea here is to make detachInstance working also with OpenStack. It will speed up rolling updates.