Force external cloud controller manager on OS #9942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
zetaab
requested changes
Sep 15, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus, zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
|
@olemarkus try to rebase this against master if the test will be fixed (after that another PR #9943 is merged) |
olemarkus
force-pushed
the
openstack-enable-eccm
branch
from
dbf2b97 to
5279047
Compare
k8s-ci-robot
removed
the
lgtm
|
@olemarkus can you try rebasing one more time against master |
olemarkus
force-pushed
the
openstack-enable-eccm
branch
from
5279047 to
b8bc6d3
Compare
k8s-ci-robot
added
area/addons
size/L
k8s-ci-robot
added
the
lgtm
This test is sort of redundant when we have integration tests etc covering rendering of these templates
olemarkus
force-pushed
the
openstack-enable-eccm
branch
from
e5a3693 to
d3ae52c
Compare
k8s-ci-robot
removed
the
lgtm
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9619
Supersedes #9625
/cc @zetaab