Cilium hubble pointer

[olemarkus]

Fixes #9966

/cc @hakman @rifelpet

[hakman]

Would it be a better idea to flatten the struct? Seems that the Hubble thing is the only one.
Something like: hakman@490da20

[olemarkus]

Would it be a better idea to flatten the struct? Seems that the Hubble thing is the only one.
Something like: hakman@490da20

You would need both HubbleEnable and HubbleEnableMetrics.
The primary use case for hubble is to attach hubble-ui or similar to it and view things like service graphs and such. EnableMetrics just enables some prometheus metrics in addition like number of drops per service etc.

[hakman]

HubbleMetrics is an array, enable/disable can be based on number of items. In any case, was just a suggestion. Structs seems to complicate templates.

[olemarkus]

So HubbleMetrics already determines if prometheus metrics should be enabled or not by the number of items. But one may want to enable hubble without any prometheus metrics enabled.

[hakman]

OK, I understand. It was not meant as an alternate PR, just a suggestion.
The point was not to complicate the code unnecessarily with extra structs and pointer validations. I don't mind either way.

[olemarkus]

Yep. Thanks for the suggestion :)
As long as one uses options builders, one can get away with quite a bit of pointer checks. More annoying that any non-nil bool pointer is evaluated as true by sprig ...

[olemarkus]

/test pull-kops-e2e-cni-cilium

[rifelpet]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rifelpet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment