Add label to prevent kops-controller from running on old nodes #9998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/addons
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
nodeselector is added to kops-controller fine. However, when I rolling update nodes in openstack the new nodes will not get needed labels -> kops-controller is not provisioned at all |
|
The label should be applied by protokube. Is the process different for OpenStack? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a label and nodeSelector to prevent kops-controller from running on nodes that were created with an older version of kops (and thus don't have the necessary PKI files provisioned by nodeup).
Fixes #9953
Upgrading a 3-node control plane from kops 1.18.1 appears to be working.