Endpoint properly handles Accept header

[roycaihw]

Sort Accept header with q parameter

NOTE: I manually changed Godep.json. goautoneg is used in kubernetes already.

[roycaihw]

cc @liggitt

[liggitt]

nit, might be more readable unnested like this:

if clause.Type != accepts.Type && clause.Type != "*" {
  continue
}
if clause.SubType != accepts.SubType && clause.SubType != "*" {
  continue
}

data, etag, lastModified := accepts.GetDataAndETag()
w.Header().Set("Etag", etag)
// ServeContent will take care of caching using eTag.
http.ServeContent(w, r, servePath, lastModified, bytes.NewReader(data))
return

[roycaihw]

updated

[liggitt]

just noticed there are no tests in this package... probably worthwhile to test here before doing a vendor cycle into kube

[roycaihw]

@liggitt I've added the test for Accept header's behavior. Please take a look :)

[roycaihw]

@mbohlool @liggitt Could we merge this one before the code slush, to avoid changing the deprecation schedule?

[liggitt]

code change LGTM
it's a little concerning that vendoring has to be updated manually in this repo

[mbohlool]

@liggitt I agree, we need to port some of the main repo tools to this repo or develop a set of generic tool from them for any repo like this.

[mbohlool]

this code looks good to me too.