Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo fix "definition"->"definitions" #39

Closed
wants to merge 1 commit into from
Closed

Typo fix "definition"->"definitions" #39

wants to merge 1 commit into from

Conversation

AdamDang
Copy link
Contributor

line 162: "all used definition in the provided spec" .
line 175: "all definition used by it "
"definitions" should be used there.

@AdamDang
Typo fix "definition"->"definitions"
4191e6a 
line 162: "all used definition in the provided spec" .
line 175: "all definition used by it "
 "definitions" should be used there.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2018
@mbohlool
Copy link
Contributor

mbohlool commented Apr 2, 2018

Can you please send one single PR/commit for all of typo fixes?

@mbohlool mbohlool closed this Apr 2, 2018
@AdamDang
Copy link
Contributor Author

AdamDang commented Apr 3, 2018

Hi @mbohlool
Thanks for your reply. I started to send PR in github from about 1 month ago. At that time, I knew little
about the github, such as how to change two or more different files in one PR. Now I've got such skills. I'm glad to join the github and do something to make the codes better, and happy for those who helping me get skilled.
BTW, is the openapi project maintained monthly?

@mbohlool
Copy link
Contributor

BTW, is the openapi project maintained monthly?

No, I was on vacation :)

sttts pushed a commit to sttts/kube-openapi that referenced this pull request Nov 5, 2020
@elakito @casualjim
Recognize path parameters in path segment fragments kubernetes#39
d509235
sttts pushed a commit to sttts/kube-openapi that referenced this pull request Nov 5, 2020
@casualjim
Merge pull request kubernetes#39 from databus23/patch-1
bfb48d3 
Don't drop empty arrays of operations security definitions
sttts pushed a commit to sttts/kube-openapi that referenced this pull request Nov 5, 2020
@databus23
Avoid null value when serializing operations
967b480 
This fixes a regression introduced by kubernetes#39.
Turns out security: null breaks the validator as it expected either no field at all or an array.

OperatioProperties now have a custom marshaller that ensures that:
1. empty slices are preserved as empty arrays in JSON
2. if Security is unset/nil the key is omitted in JSON
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdamDang @mbohlool @k8s-ci-robot