Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add collected resource objects length log #254

Merged

Conversation

andyxning
Copy link
Member

@andyxning andyxning commented Sep 12, 2017

This PR will add the log about collected resource object number. This may be useful for debug as described in #122 comment.

/cc @brancz @fabxc


This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 12, 2017
@andyxning andyxning mentioned this pull request Sep 12, 2017
@brancz
Copy link
Member

brancz commented Sep 13, 2017

good idea! lgtm 👍

@brancz brancz merged commit f0f94b3 into kubernetes:master Sep 13, 2017
@andyxning andyxning deleted the add_collected_resource_objects_length_log branch September 13, 2017 09:53
while1malloc0 pushed a commit to while1malloc0/kube-state-metrics that referenced this pull request Jul 2, 2018
…ce_objects_length_log

add collected resource objects length log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants