Skip to content

Commit

Permalink
Avoid linking to the "master" branch of repositories
Browse files Browse the repository at this point in the history
The the "master" -> "main" branch rename can happen in k8s repositories,
in the near future, which will break the links in this repository.

We can avoid referencing a "master" branch if the URL:
"https://git.k8s.io/repo" is used instead of
"https://github.com/kubernetes/{blob|tree}/master""
  • Loading branch information
neolit123 committed Sep 30, 2020
1 parent c98ac65 commit 2e8085e
Show file tree
Hide file tree
Showing 44 changed files with 140 additions and 140 deletions.
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ These pages cover topics such as installation steps, troubleshooting and command
You can help `kubeadm` **a lot** by filling issue reports for inconsistencies and keeping the documentation up-to-date by submitting PRs.

The process for contributing to the website is very straight forward and is outlined here:
* https://github.com/kubernetes/website/blob/master/CONTRIBUTING.md
* https://git.k8s.io/website/CONTRIBUTING.md

Here is a document that explains the process of updating the `kubeadm` command line reference:
* https://github.com/kubernetes/kubeadm/blob/master/docs/updating-command-reference.md
* https://git.k8s.io/kubeadm/docs/updating-command-reference.md

### Building

Expand All @@ -52,7 +52,7 @@ or kubeadm and how to test them.

### Adding dependencies

If your patch depends on new packages, add that package with [`godep`](https://github.com/tools/godep). Follow the [instructions to add a dependency](https://github.com/kubernetes/community/blob/master/contributors/devel/development.md).
If your patch depends on new packages, add that package with [`godep`](https://github.com/tools/godep). Follow the [instructions to add a dependency](https://git.k8s.io/community/contributors/devel/development.md).

### Running unit tests

Expand All @@ -70,7 +70,7 @@ make test-cmd WHAT=kubeadm
```

For more information about running tests in Kubernetes have a look at:
* https://github.com/kubernetes/community/blob/master/contributors/devel/sig-testing/testing.md
* https://git.k8s.io/community/contributors/devel/sig-testing/testing.md

For more general information about unit tests in Go please have a look at:
* https://golang.org/pkg/testing/
Expand Down
2 changes: 1 addition & 1 deletion OWNERS
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# See the OWNERS file documentation:
# https://github.com/kubernetes/community/blob/master/contributors/devel/owners.md
# https://git.k8s.io/community/contributors/devel/owners.md

approvers:
- luxas
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Kubeadm

The purpose of this repo is to aggregate issues filed against the [kubeadm component](https://github.com/kubernetes/kubernetes/tree/master/cmd/kubeadm).
The purpose of this repo is to aggregate issues filed against the [kubeadm component](https://git.k8s.io/kubernetes/cmd/kubeadm).

## What is Kubeadm ?
Kubeadm is a tool built to provide best-practice "fast paths" for creating Kubernetes clusters.
Expand All @@ -25,7 +25,7 @@ Kubeadm's scope is limited to the local node filesystem and the Kubernetes API,

Learn how to engage with the Kubernetes community on the [community page](https://kubernetes.io/community/).

You can reach the maintainers of this project at the [Cluster Lifecycle SIG](https://github.com/kubernetes/community/tree/master/sig-cluster-lifecycle#cluster-lifecycle-sig).
You can reach the maintainers of this project at the [Cluster Lifecycle SIG](https://git.k8s.io/community/sig-cluster-lifecycle#cluster-lifecycle-sig).

## Roadmap

Expand Down
6 changes: 3 additions & 3 deletions docs/design/design_v1.10.md
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ Other flags that are set unconditionally:
- [`DefaultTolerationSeconds`](https://kubernetes.io/docs/admin/admission-controllers/#defaulttolerationseconds) .
- [`NodeRestriction`](https://kubernetes.io/docs/admin/admission-controllers/#noderestriction) to limit what a kubelet can modify (e.g. its own pods).
- `--kubelet-preferred-address-types` to `InternalIP,ExternalIP,Hostname;` this makes `kubectl logs` and other apiserver -> kubelet communication work in environments where the hostnames of the nodes aren't resolvable.
- `requestheader-client-ca-file` to`front-proxy-ca.crt`, `proxy-client-cert-file` to `front-proxy-client.crt`, `proxy-client-key-file` to `front-proxy-client.key` , and`--requestheader-username-headers=X-Remote-User`, `--requestheader-group-headers=X-Remote-Group`, `--requestheader-extra-headers-prefix=X-Remote-Extra-`, `--requestheader-allowed-names=front-proxy-client` so the front proxy ([API Aggregation](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/api-machinery/aggregated-api-servers.md)) communication is secure.
- `requestheader-client-ca-file` to`front-proxy-ca.crt`, `proxy-client-cert-file` to `front-proxy-client.crt`, `proxy-client-key-file` to `front-proxy-client.key` , and`--requestheader-username-headers=X-Remote-User`, `--requestheader-group-headers=X-Remote-Group`, `--requestheader-extra-headers-prefix=X-Remote-Extra-`, `--requestheader-allowed-names=front-proxy-client` so the front proxy ([API Aggregation](https://git.k8s.io/community/contributors/design-proposals/api-machinery/aggregated-api-servers.md)) communication is secure.

#### Controller manager

Expand Down Expand Up @@ -323,7 +323,7 @@ Please note that

### Configure TLS-Bootstrapping for node joining

Kubeadm uses [Authenticating with Bootstrap Tokens](https://kubernetes.io/docs/admin/bootstrap-tokens/) for joining new nodes to an existing cluster; for more details see also [design proposal](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/cluster-lifecycle/bootstrap-discovery.md).
Kubeadm uses [Authenticating with Bootstrap Tokens](https://kubernetes.io/docs/admin/bootstrap-tokens/) for joining new nodes to an existing cluster; for more details see also [design proposal](https://git.k8s.io/community/contributors/design-proposals/cluster-lifecycle/bootstrap-discovery.md).

`kubeadm init` ensures that everything is properly configured for this process, and this includes following steps as well as setting API server and controller flags as already described in previous paragraphs.

Expand Down Expand Up @@ -434,7 +434,7 @@ Similarly to `kubeadm init`, also `kubeadm join` internal workflow consists of a

This is split into discovery (having the Node trust the Kubernetes Master) and TLS bootstrap (having the Kubernetes Master trust the Node).

see [Authenticating with Bootstrap Tokens](https://kubernetes.io/docs/admin/bootstrap-tokens/) , [design proposal](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/cluster-lifecycle/bootstrap-discovery.md).
see [Authenticating with Bootstrap Tokens](https://kubernetes.io/docs/admin/bootstrap-tokens/) , [design proposal](https://git.k8s.io/community/contributors/design-proposals/cluster-lifecycle/bootstrap-discovery.md).

### Preflight checks

Expand Down
6 changes: 3 additions & 3 deletions docs/design/design_v1.7.md
Original file line number Diff line number Diff line change
Expand Up @@ -185,11 +185,11 @@ kubectl label node ${master_name} node-role.kubernetes.io/master=""

#### cluster-info

This phase creates the `cluster-info` ConfigMap in the `kube-public` namespace as defined in [the Bootstrap Tokens proposal](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/cluster-lifecycle/bootstrap-discovery.md)
This phase creates the `cluster-info` ConfigMap in the `kube-public` namespace as defined in [the Bootstrap Tokens proposal](https://git.k8s.io/community/contributors/design-proposals/cluster-lifecycle/bootstrap-discovery.md)
- The `ca.crt` and the address/port of the apiserver is added to the `cluster-info` ConfigMap in the `kubeconfig` key
- Exposes the `cluster-info` ConfigMap to unauthenticated users (i.e. users in RBAC group `system:unauthenticated`)

**Note:** The access to the `cluster-info` ConfigMap _is not_ rate-limited.
**Note:** The access to the `cluster-info` ConfigMap _is not_ rate-limited.
This may or may not be a problem if you expose your master to the internet.
Worst-case scenario here is a DoS attack where an attacker uses all the in-flight requests the kube-apiserver can handle to serving the `cluster-info` ConfigMap.
TBD for v1.8
Expand Down Expand Up @@ -224,7 +224,7 @@ The `system:bootstrappers` Group is granted auto-approving status by it being ab
- The auto-approving certificate controller in the controller-manager checks whether the poster of the CSR (in this case the Bootstrap Token) can POST to
`/apis/certificates.k8s.io/certificatesigningrequests/nodeclient`. If the poster can, the controller approves the CSR.
- This makes it possible to easily revoke the auto-approving functionality by removing the `ClusterRoleBinding` that grants Bootstrap Tokens that, or you can
revoke access for all Bootstrap Tokens and instead make the auto-approving more granular by granting just a few users or tokens access to auto-approved credentials.
revoke access for all Bootstrap Tokens and instead make the auto-approving more granular by granting just a few users or tokens access to auto-approved credentials.

## `kubeadm join` phases

Expand Down
Loading

0 comments on commit 2e8085e

Please sign in to comment.