-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm init --config
is broken
#345
Comments
Automatic merge from submit-queue kubeadm: fix broken `kubeadm init --config` flag **What this PR does / why we need it**: This code was changed in ea19649 (#43558) to validate that `--config` wasn't passed along with other flags. Unfortunately, the implementation was checking `PersistentFlags()`, which was not parsed at the point it was being validated. The fix is to use `Flags()` instead, which contains the expected data. **Which issue this PR fixes** fixes kubernetes/kubeadm#345 **Special notes for your reviewer**: This is a regression that was cherry picked (#48577) into the `release-1.7` branch. We should fix this before the next 1.7 point release. This is awkward to unit test without restructuring the code. I think this command parsing code would be a good candidate for some higher level tests. **Release note**: ```release-note Fix a regression that broke the `--config` flag for `kubeadm init`. ``` /assign @luxas
Merged to master and cherrypick is approved. Thanks! |
do you tell me how install previous version on ubuntu??? same issue
|
@luxas @mattmoyer @caesarxuchao I tried compiling but get this error:
Error
|
@jujes sorry to hear that. It looks like you need more available memory on your build machine. The fix for this bug should be backported to the next 1.7 point release (1.7.2) sometime soon. Unfortunately, I don't know exactly when that will be available. The PR to watch is kubernetes/kubernetes#48946. |
@mattmoyer Planned sometime this week, depending on test health |
hi @mattmoyer thanks for reply my issue until sometime soon and from the last 4 days I spend a lot of time trying to work with kubeadm, I think kubeadm is vital piece for beginners like me, following this idea, I sugest offer an clear guide for use stable version or a way to change it for a previus working version... I need pass etcd: endpoints: into --config file.yaml what is only possible using this file, no way under flag definitions?? @luxas @caesarxuchao thanks in advance, |
I'm working around this issue on Ubuntu by manually installing kubeadm version 1.7.0:
@luxas note this bug breaks your kubeadm-workshop script: https://github.com/luxas/kubeadm-workshop/blob/master/e2e-script.sh#L1 |
@jbw976 I know. Fix is in for v1.7.2 which is coming tomorrow |
….1 update on kubeadm (kubernetes/kubeadm#345)
Is this a BUG REPORT or FEATURE REQUEST?
BUG REPORT
Versions
kubeadm version (use
kubeadm version
):Environment:
kubectl version
): v1.7.0What happened?
I ran
kubeadm init --config /path/to/my/config.yaml
(with no additional arguments) and got this output:What you expected to happen?
I expected
kubeadm
to load my YAML configuration. Thecan not mix '--config' with other arguments
error should only occur if other flags are also passed.How to reproduce it (as minimally and precisely as possible)?
minimal.yaml
:kubeadm init --config minimal.yaml
Anything else we need to know?
This was introduced in kubernetes/kubernetes#43558 (13 days ago). That change was also cherry picked into the
release-1.7
branch, so we need to be careful to avoid releasing a regression on 1.7.I'm working on a fix for this.
cc @luxas (Slack discussion from earlier today)
The text was updated successfully, but these errors were encountered: