Update deb/rpm manifests #442
Assignees
Labels
area/releasing
priority/critical-urgent
Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
Comments
luxas
added
area/releasing
priority/critical-urgent
|
I accept this grave responsibility. :-) |
|
I'm going to work on adding this to the deb/rpm release tooling so that we don't accidentally bundle the wrong version of CC @mikedanese |
pipejakob
added a commit
to pipejakob/release
that referenced
this issue
Sep 26, 2017
For kubeadm 1.8, we changed the flags we want to start kubelet with.
This change breaks 10-kubeadm.conf into two files (pre- and post-1.8)
and selects which one to use at build time, based on the target version.
I've also included unit tests for the new functionality, but they aren't
run by default ("go test" manually), but are meant to demonstrate the
versioning edge cases I tested.
A similar change still needs to happen for our rpm build scripts.
kubernetes/kubeadm#442
pipejakob
added a commit
to pipejakob/release
that referenced
this issue
Sep 26, 2017
For kubeadm 1.8, we changed the flags we want to start kubelet with.
This change breaks 10-kubeadm.conf into two files (pre- and post-1.8)
and selects which one to use at build time, based on the target version.
I've also included unit tests for the new functionality, but they aren't
run by default ("go test" manually), but are meant to demonstrate the
versioning edge cases I tested.
A similar change still needs to happen for our rpm build scripts.
kubernetes/kubeadm#442
pipejakob
added a commit
to pipejakob/release
that referenced
this issue
Sep 26, 2017
For kubeadm 1.8, we changed the flags we want to start kubelet with.
This change breaks 10-kubeadm.conf into two files (pre- and post-1.8)
and selects which one to use at build time, based on the target version.
I've also included unit tests for the new functionality which aren't run
by default ("go test" manually), but are meant to demonstrate the
versioning edge cases I tested.
A similar change still needs to happen for our rpm build scripts.
kubernetes/kubeadm#442
pipejakob
added a commit
to pipejakob/release
that referenced
this issue
Sep 27, 2017
For kubeadm 1.8, we changed the flags we want to start kubelet with.
This change breaks 10-kubeadm.conf into two files (pre- and post-1.8)
and selects which one to use at build time, based on the target version.
I've also included unit tests for the new functionality which aren't run
by default ("go test" manually), but are meant to demonstrate the
versioning edge cases I tested.
A similar change still needs to happen for our rpm build scripts.
kubernetes/kubeadm#442
|
@pipejakob addressed this some days ago in kubernetes/release#413 |
justaugustus
pushed a commit
to justaugustus/release
that referenced
this issue
Jun 10, 2019
For kubeadm 1.8, we changed the flags we want to start kubelet with.
This change breaks 10-kubeadm.conf into two files (pre- and post-1.8)
and selects which one to use at build time, based on the target version.
I've also included unit tests for the new functionality which aren't run
by default ("go test" manually), but are meant to demonstrate the
versioning edge cases I tested.
A similar change still needs to happen for our rpm build scripts.
kubernetes/kubeadm#442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Basically flipping the versions to v1.8.0 when released and updating the kubelet manifests to match https://github.com/kubernetes/kubernetes/blob/master/build/debs/kubeadm-10.conf
We might also have to run
systemctl daemon-reloadinkubeadmorkubeletpostinst as discussed with @jessicaochen@pipejakob can you please take ownership over getting this done and pushing the debs on release day?
The text was updated successfully, but these errors were encountered: