Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have DaemonSet controller use predicates.GeneralPredicates #21454

Closed
davidopp opened this issue Feb 18, 2016 · 4 comments · Fixed by #28803
Closed

Have DaemonSet controller use predicates.GeneralPredicates #21454

davidopp opened this issue Feb 18, 2016 · 4 comments · Fixed by #28803
Assignees
@HaiyangDING
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@davidopp
Copy link
Member

Once #20204 is submitted, we should have the DaemonSet controller use predicates.GeneralPredicates. Then we won't have to worry about the rules getting out of sync anymore.

Assigned to @HaiyangDING

cc/ @mikedanese
@davidopp davidopp added priority/backlog Higher priority than priority/awaiting-more-evidence. team/control-plane labels Feb 18, 2016
@HaiyangDING
Copy link

Thanks for filing up a new issue. This should be part of #20204, but I just chose not to implement in it for the sake of simplicity. Anyway, I will do this in a follow up PR once #20204 accepted.

@mikedanese
Copy link
Member

We should also move kubelet to predicates.GeneralPredicates

@davidopp
Copy link
Member Author

We should also move kubelet to predicates.GeneralPredicates

That's in #20204, see changes to kubelet.go

@davidopp
Copy link
Member Author

cc/ @madhusudancs @bgrant0607

@lukaszo lukaszo mentioned this issue Jul 11, 2016
Merged
k8s-github-robot pushed a commit that referenced this issue Jul 19, 2016
Merge pull request #28803 from lukaszo/ds
a049a97 
Automatic merge from submit-queue

Make Daemonset use GeneralPredicates

fixes: #21454 #22205
zefciu pushed a commit to zefciu/kubernetes that referenced this issue Jul 28, 2016
@lukaszo @zefciu
Make Daemonset use GeneralPredicates
fa2cc45 
fixes kubernetes#21454, fixes kubernetes#22205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HaiyangDING HaiyangDING

Labels
priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Daemonset use GeneralPredicates
3 participants
@mikedanese @davidopp @HaiyangDING