Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #115377: Fetch go version using gimme if needed #115497

Merged
merged 3 commits into from
Mar 1, 2023
Merged

Automated cherry pick of #115377: Fetch go version using gimme if needed #115497

merged 3 commits into from
Mar 1, 2023

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Feb 3, 2023 •
edited
Loading

Cherry pick of #115377 on release-1.25.

#115377: Fetch go version using gimme if needed

For details on the cherry pick process, see the cherry pick requests page.

The go version defined in `.go-version` is now fetched when invoking test, build, and code generation targets if the current go version does not match it. Set $FORCE_HOST_GO=y while testing or building to skip this behavior, or set $GO_VERSION to override the selected go version.

@liggitt
Defer builds to test-cmd and test-integration targets
441276c
@liggitt
Add gimme
8b8eee4
@liggitt
Invoke gimme from kube::golang::verify_go_version
029bde8 
Defaults to ensuring .go-version is used
Override the go version by setting GO_VERSION=1.x
Force using the host go version with FORCE_HOST_GO=y
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 3, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Feb 3, 2023
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 3, 2023
@liggitt liggitt changed the title Automated cherry pick of #115377: Defer builds to test-cmd and test-integration targets WIP - Automated cherry pick of #115377: Fetch go version using gimme if needed Feb 3, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2023
@k8s-ci-robot k8s-ci-robot requested review from dims and hwdef February 3, 2023 05:04
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 3, 2023
@liggitt
Copy link
Member Author

liggitt commented Feb 3, 2023

/test pull-kubernetes-integration-go-compatibility
/test pull-kubernetes-unit-go-compatibility

@liggitt
Copy link
Member Author

liggitt commented Feb 3, 2023

green go-compatibility unit and integration tests demonstrate release-1.25 builds and passes tests on libraries with the original go version for 1.25 🎉 (not surprising, since 1.25 started on go1.19)

@liggitt
Copy link
Member Author

liggitt commented Feb 3, 2023

Even before merge, this PR is useful to exercise the -go-compatibility presubmits.

Merging this will simplify testing of new go versions, which kubernetes/enhancements#3744 anticipates happening for 1.25 with an eventual update to go1.20.

That said, I think we should wait to merge this at least until the following occur with #115377:

  • we go through an actual release on master (e.g. 1.27.0-alpha.2 in a couple weeks) to prove that works with release tooling
  • we go through an actual go bump on master (e.g. the go1.20 bump in [go] Bump images, dependencies and versions to go 1.20 #114502) to prove there's no issues straddling go1.19/go1.20 with this change

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2023
@liggitt liggitt changed the title WIP - Automated cherry pick of #115377: Fetch go version using gimme if needed Automated cherry pick of #115377: Fetch go version using gimme if needed Feb 3, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2023
@liggitt liggitt mentioned this pull request Feb 3, 2023
Merged
@liggitt
Copy link
Member Author

liggitt commented Mar 1, 2023

/hold cancel

cc @dims for lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2023
@liggitt
Copy link
Member Author

liggitt commented Mar 1, 2023

/kind feature
/sig release testing

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 1, 2023
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 1, 2023
@dims
Copy link
Member

dims commented Mar 1, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6c7aa07d2ac04dfdc1b46fb21c81cba9c6799ecb

@liggitt
Copy link
Member Author

liggitt commented Mar 1, 2023

cc @kubernetes/release-managers

cpanato
cpanato approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/triage accepted
/priority important-soon
/lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 1, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 1, 2023
@cpanato cpanato added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 1, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b43fa62 into kubernetes:release-1.25 Mar 1, 2023
@liggitt liggitt deleted the automated-cherry-pick-of-#115377-upstream-release-1.25 branch March 3, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@dims dims Awaiting requested review from dims

@hwdef hwdef Awaiting requested review from hwdef

Assignees

@dims dims

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
4 participants
@liggitt @dims @k8s-ci-robot @cpanato