Add GetDeviceNameFromMount in mount_unsupported.go #30724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add GetDeviceNameFromMount in mount_unsupported.go
k8s-github-robot
added
size/XS
|
LGTM |
saad-ali
added
the
lgtm
saad-ali
added
cherrypick-candidate
release-note-none
|
Can you add a compile-time check (in follow up PR) to prevent this from happening again, something like: // Compile-time check to ensure Mounter implements the mount interface
var _ Interface = &Mounter{} |
|
GCE e2e build/test passed for commit 89de4f2. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 89de4f2. |
|
Automatic merge from submit-queue |
This was referenced Aug 17, 2016
fabioy
added
cherry-pick-approved
|
We have a different but similar compilation issue now: |
k8s-github-robot
pushed a commit
that referenced
this pull request
Aug 23, 2016
Automatic merge from submit-queue ensure pkg/util/mount compiles & crosses <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md 2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md 3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes --> **What this PR does / why we need it**: osx doesn't build **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #30795 **Special notes for your reviewer**: **Release note**: ```release-note-none ``` - move compile time check from linux code to generic code - remove duplication of #30724 and #30666 to resolve #30795
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…ck-of-#27970-kubernetes#30724-upstream-release-1.3 Automatic merge from submit-queue Automated cherry pick of kubernetes#27970 kubernetes#30724 Cherry pick of kubernetes#27970 kubernetes#30724 on release-1.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GetDeviceNameFromMount in mount_unsupported.go
This change is