-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Azure global rate limit to per client #86515
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-e2e-aks-engine-azure |
/assign @andyzhangx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
is there upgrade test from old config to new config, make sure old config still works in new config?
@andyzhangx yep, old configured rate limits are still working. |
/test pull-kubernetes-e2e-aks-engine-azure |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test pull-kubernetes-e2e-gce |
What type of PR is this?
/kind feature
/area provider/azure
/priority important-soon
/sig cloud-provider
What this PR does / why we need it:
Change Azure global rate limit to per client, so that one client's rate limit issue won't block another client.
Example configure:
Which issue(s) this PR fixes:
Fixes #86019
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: