Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate scheduling_duration_seconds Summary metric #86586

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Deprecate scheduling_duration_seconds Summary metric #86586

merged 1 commit into from
Jan 3, 2020

Conversation

xiaoanyunfei
Copy link
Contributor

@xiaoanyunfei xiaoanyunfei commented Dec 24, 2019 •
edited
Loading

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

Deprecate scheduling_duration_seconds Summary metric

Which issue(s) this PR fixes:

Ref # #86391

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Marked scheduler's scheduling_duration_seconds Summary metric as deprecated

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig scheduling
/assign @liu-cong

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 24, 2019
@liu-cong
Copy link
Contributor

liu-cong commented Jan 2, 2020

/lgtm

@ahg-g , can you take a quick look?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2020
@ahg-g
Copy link
Member

ahg-g commented Jan 2, 2020 •
edited
Loading

Please update "Does this PR introduce a user-facing change?:" with "Marked scheduler's scheduling_duration_seconds Summary metric as deprecated"

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 3, 2020
@xiaoanyunfei
Copy link
Contributor Author

Please update "Does this PR introduce a user-facing change?:" with "Marked scheduler's scheduling_duration_seconds Summary metric as deprecated"

done

@ahg-g
Copy link
Member

ahg-g commented Jan 3, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, xiaoanyunfei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit fdfcb00 into kubernetes:master Jan 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 3, 2020
@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Jun 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draveness draveness Awaiting requested review from draveness

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@liu-cong liu-cong

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@xiaoanyunfei @liu-cong @ahg-g @k8s-ci-robot