Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated fields from kubescheduler.config.k8s.io/v1alpha2 #87904

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Remove deprecated fields from kubescheduler.config.k8s.io/v1alpha2 #87904

merged 1 commit into from
Feb 7, 2020

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Feb 6, 2020 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

These flags are deprecated, so they can be removed from new version.

Which issue(s) this PR fixes:

Refs #87617

Does this PR introduce a user-facing change?:

Remove deprecated fields from .leaderElection in kubescheduler.config.k8s.io/v1alpha2

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 6, 2020
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 6, 2020
@alculquicondor
Copy link
Member Author

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Feb 6, 2020 •
edited
Loading

removal looks fine, unit tests and build are unhappy

@alculquicondor
Copy link
Member Author

I forgot to remove the fields from defaults 😓

@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@alculquicondor
Copy link
Member Author

/retest

@alculquicondor
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@alculquicondor
Copy link
Member Author

Tests passing 😃

friendly ping @liggitt

@liggitt
Copy link
Member

liggitt commented Feb 7, 2020

/priority important-soon
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2020
k8s-ci-robot added a commit that referenced this pull request Feb 7, 2020
@k8s-ci-robot
Merge pull request #87904 from alculquicondor/rm_v1alpha2_deprecated
9617322 
Remove deprecated fields from kubescheduler.config.k8s.io/v1alpha2
@k8s-ci-robot k8s-ci-robot merged commit 9617322 into kubernetes:master Feb 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1071eb8 into kubernetes:master Feb 7, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@vishh vishh Awaiting requested review from vishh

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@alculquicondor @liggitt @fejta-bot @k8s-ci-robot