Sort rejected drivers by their preference order

[afbjorklund]

Don't show drivers not being selected by default

Closes #10009

BEFORE

• Unable to pick a default driver. Here is what was considered, in preference order:
  • vmware: Not installed: exec: "docker-machine-driver-vmware": executable file not found in $PATH
  • docker: Not installed: exec: "docker": executable file not found in $PATH
  • kvm2: Not installed: exec: "virsh": executable file not found in $PATH
  • none: Not installed: exec: "iptables": executable file not found in $PATH
  • podman: Not installed: exec: "podman": executable file not found in $PATH
  • virtualbox: Not installed: unable to find VBoxManage in $PATH

AFTER

• Unable to pick a default driver. Here is what was considered, in preference order:
  • docker: Not installed: exec: "docker": executable file not found in $PATH
  • kvm2: Not installed: exec: "virsh": executable file not found in $PATH
  • vmware: Not installed: exec: "docker-machine-driver-vmware": executable file not found in $PATH
  • podman: Not installed: exec: "podman": executable file not found in $PATH
  • virtualbox: Not installed: unable to find VBoxManage in $PATH

The priority was being clobbered for unhealthy drivers, so save original priority as "preference"

[medyagh]

@afbjorklund LoadImage test is consistently failing all on GH action tests
"TestFunctional/parallel/LoadImage"
Could it be from this PR ?

#11063

[medyagh]

/ok-to-test

[medyagh]

/ok-to-test

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11355) |
+----------------+----------+---------------------+
| minikube start | 51.5s    | 51.8s               |
| enable ingress | 70.8s    | 41.3s               |
+----------------+----------+---------------------+

Times for minikube start: 48.8s 56.0s 53.1s 48.5s 51.0s
Times for minikube (PR 11355) start: 56.6s 48.3s 48.8s 51.0s 54.4s

Times for minikube ingress: 35.3s 35.2s 34.3s 215.3s 33.8s
Times for minikube (PR 11355) ingress: 36.4s 41.8s 33.9s 34.8s 59.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11355) |
+----------------+----------+---------------------+
| minikube start | 21.9s    | 22.1s               |
| enable ingress | 30.1s    | 54.1s               |
+----------------+----------+---------------------+

Times for minikube start: 22.7s 21.5s 21.7s 21.5s 22.1s
Times for minikube (PR 11355) start: 21.9s 21.9s 22.1s 21.7s 22.7s

Times for minikube ingress: 33.0s 28.1s 28.0s 32.0s 29.5s
Times for minikube (PR 11355) ingress: 30.5s 28.0s 34.0s 124.0s 54.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11355) |
+----------------+----------+---------------------+
| minikube start | 42.8s    | 46.3s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 43.0s 42.5s 42.2s 42.7s 43.4s
Times for minikube (PR 11355) start: 47.1s 46.7s 47.2s 43.4s 47.1s

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11355) |
+----------------+----------+---------------------+
| minikube start | 52.8s    | 49.5s               |
| enable ingress | 34.8s    | 35.2s               |
+----------------+----------+---------------------+

Times for minikube start: 52.2s 52.1s 54.6s 52.3s 52.8s
Times for minikube (PR 11355) start: 46.6s 48.2s 51.6s 49.2s 51.7s

Times for minikube ingress: 35.3s 35.8s 34.3s 34.2s 34.3s
Times for minikube (PR 11355) ingress: 34.8s 34.8s 36.7s 35.3s 34.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11355) |
+----------------+----------+---------------------+
| minikube start | 21.6s    | 21.6s               |
| enable ingress | 30.5s    | 31.6s               |
+----------------+----------+---------------------+

Times for minikube start: 21.4s 20.9s 21.8s 22.8s 21.1s
Times for minikube (PR 11355) start: 22.1s 21.9s 21.3s 21.4s 21.2s

Times for minikube ingress: 29.0s 30.0s 28.5s 34.0s 31.0s
Times for minikube (PR 11355) ingress: 37.0s 34.0s 29.1s 28.1s 30.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11355) |
+----------------+----------+---------------------+
| minikube start | 46.8s    | 44.7s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 48.5s 47.1s 48.9s 47.0s 42.7s
Times for minikube (PR 11355) start: 43.3s 47.2s 43.5s 43.0s 46.7s

[afbjorklund]

Note that this PR only changes the output to the user. The actual bug fix was in PR #11371

[k8s-ci-robot]

@afbjorklund: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-minikube-build	610883b	link	/test pull-minikube-build

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[minikube-pr-bot]

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11355) |
+----------------+----------+---------------------+
| minikube start | 49.6s    | 49.5s               |
| enable ingress | 36.0s    | 35.0s               |
+----------------+----------+---------------------+

Times for minikube start: 52.9s 47.8s 47.9s 52.2s 47.4s
Times for minikube (PR 11355) start: 54.1s 47.7s 49.4s 48.8s 47.8s

Times for minikube ingress: 41.3s 35.2s 34.2s 35.2s 34.3s
Times for minikube (PR 11355) ingress: 34.2s 34.3s 33.8s 34.7s 37.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11355) |
+----------------+----------+---------------------+
| minikube start | 22.2s    | 21.5s               |
| enable ingress | 30.7s    | 31.5s               |
+----------------+----------+---------------------+

Times for minikube start: 22.2s 22.9s 22.3s 21.7s 21.9s
Times for minikube (PR 11355) start: 21.8s 21.5s 21.1s 21.7s 21.7s

Times for minikube ingress: 28.0s 28.5s 37.0s 29.0s 31.0s
Times for minikube (PR 11355) ingress: 29.5s 28.5s 37.0s 30.0s 32.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 11355) |
+----------------+----------+---------------------+
| minikube start | 43.1s    | 45.6s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.4s 42.8s 47.2s 46.9s 47.1s
Times for minikube (PR 11355) start: 46.9s 43.0s 42.5s 48.0s 47.4s

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [afbjorklund]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment