-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore previous support for progressbar pool #11673
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afbjorklund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Apparently this might break things on Windows, so should disable it there. |
hm...how about we use V3 in windows ? ( I think any progress bar is better than no progress bar ? ) we had a lot of users complanining they hate to wait looking at nothing when somehting was being downloaded |
I was just wondering how bad V1 was on Windows, without the pool... But the progressbar should probably be abstracted into a separate class. |
good idea lets do that |
So a new PR for that. |
Now shows output on two different lines instead of just one:
Had to downgrade github.com/cheggaaa/pb from V3 to V1 for it.
Pool was removed earlier in 7fa4e05
Closes #11069