Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore previous support for progressbar pool #11673

Closed
wants to merge 4 commits into from

Conversation

afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Jun 16, 2021

Now shows output on two different lines instead of just one:

🚜  Pulling base image ...
💾  Downloading Kubernetes v1.20.7 preload ...
    > preloaded-images-k8s-v11-v1...:  492.20 MiB / 492.20 MiB  100.00% 22.08 MiB/s 22s01s
    > gcr.io/k8s-minikube/kicbase...:  359.09 MiB / 359.09 MiB  7.50 MiB/s 47s 

Had to downgrade github.com/cheggaaa/pb from V3 to V1 for it.

Pool was removed earlier in 7fa4e05

Closes #11069

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@afbjorklund afbjorklund changed the title Restore previous support for progressbar pool WIP: Restore previous support for progressbar pool Jun 16, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2021
@afbjorklund
Copy link
Collaborator Author

Apparently this might break things on Windows, so should disable it there.

#4996 (comment)

@afbjorklund afbjorklund changed the title WIP: Restore previous support for progressbar pool Restore previous support for progressbar pool Jun 16, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2021
@medyagh
Copy link
Member

medyagh commented Jun 16, 2021

#4996 (comment)

hm...how about we use V3 in windows ? ( I think any progress bar is better than no progress bar ? ) we had a lot of users complanining they hate to wait looking at nothing when somehting was being downloaded

@afbjorklund
Copy link
Collaborator Author

I was just wondering how bad V1 was on Windows, without the pool...

But the progressbar should probably be abstracted into a separate class.
Then there could be different implementations for Unix and for Windows.

@medyagh
Copy link
Member

medyagh commented Jun 17, 2021

I was just wondering how bad V1 was on Windows, without the pool...

But the progressbar should probably be abstracted into a separate class.
Then there could be different implementations for Unix and for Windows.

good idea lets do that

@afbjorklund
Copy link
Collaborator Author

So a new PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI progress bars stepping on each other
3 participants