Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade Dashboard addon from v2.5.1 to v2.6.0, MetricsScraper from v1.0.7 to v1.0.8 #14269

Merged
merged 3 commits into from
Jun 2, 2022
Merged

upgrade Dashboard addon from v2.5.1 to v2.6.0, MetricsScraper from v1.0.7 to v1.0.8 #14269

merged 3 commits into from
Jun 2, 2022

Conversation

ziyi-xie
Copy link
Contributor

@ziyi-xie ziyi-xie commented Jun 2, 2022

This PR fixed the version of Dashboard to v2.6.0, and MetricsScraper to v1.0.8 in minikube.
https://github.com/kubernetes/dashboard/releases
https://github.com/kubernetes-sigs/dashboard-metrics-scraper/releases

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 2, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @ziyi-xie. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 2, 2022
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@ziyi-xie
Copy link
Contributor Author

ziyi-xie commented Jun 2, 2022

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2022
@shu-mutou
Copy link

Thanks for updating dashboard!
Not to be confused in updating in the future, could you change versions to vX.X.X in following comments?

minikube/test/integration/start_stop_delete_test.go

Line 451 in 919e0da

// "kubernetesui/dashboard:v2.5.1"

@ziyi-xie
Copy link
Contributor Author

ziyi-xie commented Jun 2, 2022

Thanks for updating dashboard! Not to be confused in updating in the future, could you change versions to vX.X.X in following comments?

minikube/test/integration/start_stop_delete_test.go

Line 451 in 919e0da

// "kubernetesui/dashboard:v2.5.1"

I just modified the version of dashboard in that file and thank you so much for your comments!

@ziyi-xie
Copy link
Contributor Author

ziyi-xie commented Jun 2, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2022
@shu-mutou
Copy link

LGTM. Thanks!

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 2, 2022
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14269) |
+----------------+----------+---------------------+
| minikube start | 53.2s    | 51.8s               |
| enable ingress | 28.8s    | 29.7s               |
+----------------+----------+---------------------+

Times for minikube start: 55.0s 51.7s 51.1s 55.8s 52.3s
Times for minikube (PR 14269) start: 51.4s 51.3s 52.3s 51.3s 52.7s

Times for minikube ingress: 28.2s 30.2s 26.7s 29.6s 29.1s
Times for minikube (PR 14269) ingress: 30.2s 29.7s 28.7s 31.2s 28.7s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14269) |
+----------------+----------+---------------------+
| minikube start | 27.1s    | 26.6s               |
| enable ingress | 22.9s    | 22.6s               |
+----------------+----------+---------------------+

Times for minikube start: 32.4s 25.9s 25.9s 25.6s 25.8s
Times for minikube (PR 14269) start: 26.3s 26.1s 25.9s 25.6s 28.9s

Times for minikube ingress: 23.0s 23.0s 22.5s 23.0s 23.0s
Times for minikube (PR 14269) ingress: 23.0s 22.0s 23.0s 22.0s 23.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 14269) |
+----------------+----------+---------------------+
| minikube start | 31.5s    | 31.3s               |
| enable ingress | 22.9s    | 27.1s               |
+----------------+----------+---------------------+

Times for minikube start: 31.7s 29.7s 29.5s 33.2s 33.4s
Times for minikube (PR 14269) start: 30.6s 29.8s 32.9s 30.1s 33.0s

Times for minikube ingress: 23.0s 32.5s 22.0s 18.5s 18.5s
Times for minikube (PR 14269) ingress: 22.0s 22.0s 19.0s 22.5s 50.0s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
Docker_Linux TestAddons/parallel/Registry (gopogh) 1.88 (chart)
Docker_Linux TestFunctional/parallel/PersistentVolumeClaim (gopogh) 1.88 (chart)
Docker_Linux TestMultiNode/serial/DeployApp2Nodes (gopogh) 1.88 (chart)
Docker_Linux TestMultiNode/serial/PingHostFrom2Pods (gopogh) 1.88 (chart)
Docker_Linux TestFunctional/parallel/DashboardCmd (gopogh) 2.50 (chart)
Docker_Linux TestStartStop/group/default-k8s-different-port/serial/AddonExistsAfterStop (gopogh) 2.50 (chart)
Docker_Linux TestStartStop/group/default-k8s-different-port/serial/SecondStart (gopogh) 2.50 (chart)
Docker_Linux TestStartStop/group/default-k8s-different-port/serial/UserAppExistsAfterStop (gopogh) 2.50 (chart)
Docker_Linux TestStartStop/group/default-k8s-different-port/serial/VerifyKubernetesImages (gopogh) 2.50 (chart)
Docker_Linux TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh) 3.12 (chart)
Docker_macOS TestNetworkPlugins/group/cilium/Start (gopogh) 5.43 (chart)
KVM_Linux_containerd TestStoppedBinaryUpgrade/Upgrade (gopogh) 7.83 (chart)
Docker_Linux TestNetworkPlugins/group/auto/DNS (gopogh) 8.28 (chart)
Hyperkit_macOS TestFunctional/serial/ComponentHealth (gopogh) 10.57 (chart)
Docker_Windows TestNetworkPlugins/group/auto/DNS (gopogh) 13.33 (chart)
Docker_Linux TestNetworkPlugins/group/kindnet/Start (gopogh) 32.50 (chart)
Docker_Linux TestFunctional/serial/ComponentHealth (gopogh) 36.88 (chart)
Docker_Linux TestNetworkPlugins/group/calico/DNS (gopogh) 48.15 (chart)
Docker_Linux TestNetworkPlugins/group/false/DNS (gopogh) 50.00 (chart)
Docker_Windows TestNetworkPlugins/group/false/Start (gopogh) 57.78 (chart)
Docker_Windows TestKubernetesUpgrade (gopogh) 59.26 (chart)
Docker_Windows TestNetworkPlugins/group/kindnet/Start (gopogh) 69.63 (chart)
Docker_Windows TestNetworkPlugins/group/kubenet/Start (gopogh) 72.59 (chart)
Docker_Windows TestStartStop/group/newest-cni/serial/Pause (gopogh) 73.44 (chart)
Docker_Linux TestNetworkPlugins/group/bridge/DNS (gopogh) 74.38 (chart)
Docker_Linux TestNetworkPlugins/group/kubenet/DNS (gopogh) 75.00 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/calico/Start (gopogh) 75.20 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/enable-default-cni/DNS (gopogh) 75.97 (chart)
Docker_Linux_containerd TestNetworkPlugins/group/bridge/DNS (gopogh) 78.46 (chart)
Docker_Windows TestNetworkPlugins/group/calico/Start (gopogh) 80.00 (chart)
More tests... Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

@spowelljr spowelljr merged commit 267f021 into kubernetes:master Jun 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr, ziyi-xie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spowelljr spowelljr spowelljr approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ziyi-xie @k8s-ci-robot @minikube-bot @shu-mutou @spowelljr @minikube-pr-bot