Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kicbase: update Ubuntu base image #15991

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Conversation

spowelljr
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 7, 2023
@k8s-ci-robot k8s-ci-robot requested a review from medyagh March 7, 2023 21:02
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from prezha March 7, 2023 21:02
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2023
@medyagh
Copy link
Member

medyagh commented Mar 7, 2023

/ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

ok-to-build-image

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 10, 2023
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15991) |
+----------------+----------+---------------------+
| minikube start | 55.3s    | 56.4s               |
| enable ingress | 26.7s    | 25.7s               |
+----------------+----------+---------------------+

Times for minikube (PR 15991) start: 54.2s 56.2s 58.4s 55.3s 57.7s
Times for minikube start: 55.8s 57.4s 55.6s 51.6s 56.3s

Times for minikube ingress: 28.2s 29.7s 25.2s 25.2s 25.3s
Times for minikube (PR 15991) ingress: 25.7s 26.2s 24.3s 24.8s 27.7s

docker driver with docker runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 15991) |
+-------------------+----------+---------------------+
| minikube start    | 26.8s    | 26.2s               |
| ⚠️  enable ingress | 21.9s    | 33.2s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 26.7s 27.2s 26.8s 27.2s 26.2s
Times for minikube (PR 15991) start: 26.1s 25.8s 26.6s 26.8s 25.4s

Times for minikube ingress: 21.6s 21.5s 23.1s 23.1s 20.1s
Times for minikube (PR 15991) ingress: 21.1s 82.6s 21.1s 20.1s 21.1s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 15991) |
+----------------+----------+---------------------+
| minikube start | 22.8s    | 22.9s               |
| enable ingress | 32.2s    | 32.0s               |
+----------------+----------+---------------------+

Times for minikube (PR 15991) start: 23.3s 23.0s 23.0s 22.0s 23.2s
Times for minikube start: 22.8s 23.5s 22.7s 22.7s 22.4s

Times for minikube ingress: 32.5s 31.6s 32.6s 32.5s 31.6s
Times for minikube (PR 15991) ingress: 32.6s 32.6s 31.6s 31.6s 31.6s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux TestRunningBinaryUpgrade (gopogh) 1.27 (chart)
Docker_Linux TestMultiNode/serial/DeployApp2Nodes (gopogh) 100.00 (chart)
Docker_Linux TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressAddons (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/serial/ValidateIngressDNSAddonActivation (gopogh) 100.00 (chart)
Docker_macOS TestIngressAddonLegacy/StartLegacyK8sCluster (gopogh) 100.00 (chart)
Docker_macOS TestKubernetesUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMissingContainerUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestMultiNode/serial/DeployApp2Nodes (gopogh) 100.00 (chart)
Docker_macOS TestMultiNode/serial/PingHostFrom2Pods (gopogh) 100.00 (chart)
Docker_macOS TestRunningBinaryUpgrade (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/DeployApp (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/EnableAddonWhileActive (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/FirstStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 100.00 (chart)
Docker_macOS TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 100.00 (chart)
Docker_macOS TestStoppedBinaryUpgrade/Upgrade (gopogh) 100.00 (chart)
KVM_Linux_containerd TestPreload (gopogh) 100.00 (chart)

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit 0cdd589 into kubernetes:master Mar 13, 2023
@spowelljr spowelljr deleted the updateUbuntu branch March 13, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants