Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO: Add docker-buildx #16798

Closed
wants to merge 2 commits into from
Closed

ISO: Add docker-buildx #16798

wants to merge 2 commits into from

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Jun 30, 2023 •
edited
Loading

If you run docker build in the ISO you get the following:

DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
            Install the buildx component to build images with BuildKit:
            https://docs.docker.com/go/buildx/

So this installs the docker-buildx components to prevent deprecation

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 30, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2023
@spowelljr spowelljr changed the title Add docker buildx iso ISO: Add docker-buildx Jun 30, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 30, 2023
@afbjorklund

This comment was marked as off-topic.

Sign in to view
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,medyagh,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh
Copy link
Member

medyagh commented Jul 5, 2023

/ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, your ISO info is out of date. Please rebase.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2023
@spowelljr spowelljr force-pushed the addDockerBuildxISO branch from 696940e to 0281bea Compare July 6, 2023 20:29
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2023
@spowelljr
Copy link
Member Author

ok-to-build-iso

@spowelljr
Copy link
Member Author

ISO build failed as docker-buildx requires Go 1.20 but we're stuck on Go 1.19 for the ISO due to #15841, created a PR to update buildroot #16838

@spowelljr
Copy link
Member Author

Will reopen once #16838 is merged as it's a blocker

@spowelljr spowelljr closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund afbjorklund approved these changes

@medyagh medyagh medyagh approved these changes

@prezha prezha Awaiting requested review from prezha

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spowelljr @afbjorklund @k8s-ci-robot @medyagh @minikube-bot