Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ceph fs kernel driver to arm iso #18213

Merged
merged 2 commits into from
Mar 15, 2024
Merged

add ceph fs kernel driver to arm iso #18213

merged 2 commits into from
Mar 15, 2024

Conversation

BlaineEXE
Copy link
Contributor

The Minikube ISO for aarch64 did not contain the Ceph Filesystem kernel driver build parameters present for the x86_64 build. This is critical for running Rook (https://rook.io) storage on Minikube.

CONFIG_CEPH_LIB=y was already present, however CONFIG_CEPH_FS=m and CONFIG_CEPH_FS_POSIX_ACL=y (both present in the x86_64 image) were not present and are added here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 19, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 19, 2024
@BlaineEXE
Copy link
Contributor Author

This adds 2 kernel configs that I missed when contributing #16019 last year.

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@BlaineEXE BlaineEXE mentioned this pull request Feb 19, 2024
Closed
@BlaineEXE
Copy link
Contributor Author

I think this may also need ok-to-build-iso, but I'm not certain

nirs
nirs reviewed Feb 24, 2024
View reviewed changes
Copy link
Contributor

@nirs nirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we will need these changes soon for Ramen.
RamenDR/ramen#1192

@Fenrur
Copy link

Fenrur commented Mar 6, 2024

No news here for build the iso ?

@BlaineEXE
Copy link
Contributor Author

I saw that @afbjorklund and @medyagh approved @nirs 's PR yesterday. Do either of you have time to look at this PR? It seems like the default assigned reviewers might not have time. It's quite simple, and I've heard of a few more Rook users/devs (including myself) who are currently blocked by this.

@BlaineEXE @spowelljr
add ceph fs kernel driver to arm iso
9a60408 
The Minikube ISO for aarch64 did not contain the Ceph Filesystem kernel
driver build parameters present for the x86_64 build. This is critical
for running Rook (https://rook.io) storage on Minikube.

`CONFIG_CEPH_LIB=y` was already present, however `CONFIG_CEPH_FS=m` and
`CONFIG_CEPH_FS_POSIX_ACL=y` (both present in the x86_64 image) were not
present and are added here.

Signed-off-by: Blaine Gardner <[email protected]>
@spowelljr spowelljr force-pushed the add-cephf-modules-to-arm-iso branch from 539e9f9 to 9a60408 Compare March 14, 2024 23:37
@spowelljr
Copy link
Member

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @BlaineEXE, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 15, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18213) |
+----------------+----------+---------------------+
| minikube start | 51.6s    | 54.0s               |
| enable ingress | 25.5s    | 25.3s               |
+----------------+----------+---------------------+

Times for minikube start: 52.2s 51.6s 50.6s 51.3s 52.4s
Times for minikube (PR 18213) start: 54.0s 56.1s 52.6s 53.8s 53.5s

Times for minikube ingress: 26.7s 27.0s 26.6s 24.0s 23.0s
Times for minikube (PR 18213) ingress: 23.5s 26.1s 22.5s 28.1s 26.0s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18213) |
+----------------+----------+---------------------+
| minikube start | 24.3s    | 23.2s               |
| enable ingress | 20.6s    | 20.3s               |
+----------------+----------+---------------------+

Times for minikube start: 25.0s 25.2s 21.7s 24.9s 24.6s
Times for minikube (PR 18213) start: 22.5s 24.3s 22.4s 24.2s 22.3s

Times for minikube ingress: 20.3s 20.3s 20.3s 20.3s 21.8s
Times for minikube (PR 18213) ingress: 20.3s 20.3s 20.3s 19.8s 20.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18213) |
+----------------+----------+---------------------+
| minikube start | 22.5s    | 21.9s               |
| enable ingress | 30.2s    | 30.3s               |
+----------------+----------+---------------------+

Times for minikube start: 20.0s 20.1s 24.0s 24.2s 24.0s
Times for minikube (PR 18213) start: 21.5s 23.2s 23.4s 20.5s 20.7s

Times for minikube ingress: 30.3s 30.3s 30.3s 30.3s 29.8s
Times for minikube (PR 18213) ingress: 30.8s 31.3s 29.8s 29.8s 29.8s

@minikube-pr-bot
Copy link

These are the flake rates of all failed tests.

Environment Failed Tests Flake Rate (%)
KVM_Linux_crio TestMultiControlPlane/serial/AddSecondaryNode (gopogh) 0.00 (chart)
KVM_Linux_crio TestMultiControlPlane/serial/DegradedAfterClusterRestart (gopogh) 0.00 (chart)
KVM_Linux_crio TestMultiControlPlane/serial/DeleteSecondaryNode (gopogh) 0.00 (chart)
KVM_Linux_crio TestMultiControlPlane/serial/RestartCluster (gopogh) 0.00 (chart)
KVM_Linux TestStartStop/group/old-k8s-version/serial/Pause (gopogh) 0.00 (chart)
KVM_Linux TestStartStop/group/old-k8s-version/serial/VerifyKubernetesImages (gopogh) 0.00 (chart)
none_Linux TestDownloadOnly/v1.20.0/binaries (gopogh) 0.87 (chart)
none_Linux TestDownloadOnly/v1.20.0/json-events (gopogh) 0.87 (chart)
KVM_Linux TestStartStop/group/old-k8s-version/serial/AddonExistsAfterStop (gopogh) 17.61 (chart)
KVM_Linux TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 17.61 (chart)
KVM_Linux TestStartStop/group/old-k8s-version/serial/UserAppExistsAfterStop (gopogh) 17.61 (chart)
Docker_Linux_containerd_arm64 TestStartStop/group/old-k8s-version/serial/SecondStart (gopogh) 28.48 (chart)
QEMU_macOS TestImageBuild/serial/Setup (gopogh) 37.04 (chart)
QEMU_macOS TestJSONOutput/pause/Command (gopogh) 37.04 (chart)
QEMU_macOS TestJSONOutput/start/Command (gopogh) 37.04 (chart)
QEMU_macOS TestJSONOutput/unpause/Command (gopogh) 37.04 (chart)
QEMU_macOS TestMinikubeProfile (gopogh) 38.89 (chart)

To see the flake rates of all tests by environment, click here.

spowelljr
spowelljr approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@spowelljr spowelljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay

@spowelljr spowelljr merged commit 77d31a3 into kubernetes:master Mar 15, 2024
26 of 41 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BlaineEXE, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2024
@BlaineEXE BlaineEXE deleted the add-cephf-modules-to-arm-iso branch March 15, 2024 19:50
@BlaineEXE
Copy link
Contributor Author

Thanks! :)

@medyagh medyagh mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirs nirs nirs left review comments

@spowelljr spowelljr spowelljr approved these changes

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BlaineEXE @minikube-bot @Fenrur @spowelljr @minikube-pr-bot @k8s-ci-robot @nirs