kvm2 driver: Don't delete the "default" libvirt network #18920
Conversation
The special "default" network is created by libvirt and owned by the
system admin, but we try to delete it when deleting a profile.
To reproduce the issue, start and delete minikube on a system without
any other vm using the libvirt default network:
minikube start --driver kvm2 --network default
minikube delete
The default network will be delete, and the next minikube start will
fail, complaining about missing libvirt default networking and linking
to the complicated instructions how to recreate it.
Now we skip deletion of the special "default" network.
Example run log:
$ out/minikube delete -v10 --logtostderr 2>delete.log
* Deleting "minikube" in kvm2 ...
* Removed all traces of the "minikube" cluster.
$ cat delete.log
...
I0518 03:41:27.148838 1247331 out.go:177] * Deleting "minikube" in kvm2 ...
I0518 03:41:27.148857 1247331 main.go:141] libmachine: (minikube) Calling .Remove
I0518 03:41:27.149156 1247331 main.go:141] libmachine: (minikube) DBG | Removing machine...
I0518 03:41:27.159000 1247331 main.go:141] libmachine: (minikube) DBG | Trying to delete the networks (if possible)
I0518 03:41:27.169497 1247331 main.go:141] libmachine: (minikube) DBG | Using the default network, skipping deletion
I0518 03:41:27.169598 1247331 main.go:141] libmachine: (minikube) Successfully deleted networks
...
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @nirs. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
needs-ok-to-test
|
Can one of the admins verify this patch? |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
k8s-ci-robot
added
the
approved
|
kvm2 driver with docker runtime Times for minikube ingress: 23.9s 23.0s 26.9s 24.0s 25.4s Times for minikube start: 49.7s 50.8s 48.9s 51.4s 49.5s docker driver with docker runtime Times for minikube ingress: 21.7s 21.7s 21.8s 22.7s 21.2s Times for minikube start: 20.5s 23.3s 20.5s 23.6s 23.8s docker driver with containerd runtime Times for minikube start: 20.4s 22.7s 22.5s 23.1s 22.8s Times for minikube ingress: 31.2s 32.2s 32.2s 32.8s 31.3s |
|
These are the flake rates of all failed tests.
To see the flake rates of all tests by environment, click here. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, nirs, spowelljr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The special "default" network is created by libvirt and owned by the system admin, but we try to delete it when deleting a profile.
To reproduce the issue, start and delete minikube on a system without any other vm using the libvirt default network:
The default network will be delete, and the next minikube start will fail, complaining about missing libvirt default networking and linking to the complicated instructions how to recreate it.
Now we skip deletion of the special "default" network.
Example run log:
Fixes #18919