Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove helm-tiller addon #19636

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

tylerauerbeck
Copy link
Contributor

This PR drops the helm-tiller add-on as it has been deprecated for quite some time.

fixes #19604

Signed-off-by: Tyler Auerbeck <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 13, 2024
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Contributor

Welcome @tylerauerbeck!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @tylerauerbeck. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, tylerauerbeck

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2024
@medyagh
Copy link
Member

medyagh commented Sep 13, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 13, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19636) |
+----------------+----------+---------------------+
| minikube start | 48.0s    | 49.1s               |
| enable ingress | 16.0s    | 15.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 16.5s 16.1s 15.6s 15.0s 17.0s
Times for minikube (PR 19636) ingress: 16.0s 14.6s 16.1s 16.0s 16.0s

Times for minikube start: 47.1s 46.8s 51.0s 47.0s 48.2s
Times for minikube (PR 19636) start: 50.2s 47.0s 48.7s 50.2s 49.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19636) |
+----------------+----------+---------------------+
| minikube start | 23.7s    | 22.5s               |
| enable ingress | 13.2s    | 13.5s               |
+----------------+----------+---------------------+

Times for minikube start: 24.7s 24.6s 24.2s 23.6s 21.2s
Times for minikube (PR 19636) start: 24.3s 21.7s 24.4s 21.1s 21.1s

Times for minikube ingress: 13.9s 13.3s 13.3s 13.3s 12.4s
Times for minikube (PR 19636) ingress: 13.8s 13.3s 13.3s 13.3s 13.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 19636) |
+----------------+----------+---------------------+
| minikube start | 22.0s    | 21.7s               |
| enable ingress | 26.5s    | 23.2s               |
+----------------+----------+---------------------+

Times for minikube start: 22.6s 20.5s 23.8s 19.8s 23.3s
Times for minikube (PR 19636) start: 20.6s 23.5s 20.4s 20.7s 23.5s

Times for minikube ingress: 22.8s 22.8s 39.8s 24.3s 22.8s
Times for minikube (PR 19636) ingress: 23.8s 22.8s 23.8s 22.8s 22.8s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

@medyagh medyagh merged commit f4ded19 into kubernetes:master Sep 19, 2024
35 of 50 checks passed
@tylerauerbeck tylerauerbeck deleted the remove-tiller branch September 21, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove helm tiller add-on
5 participants