Full support for custom service cluster ip range #2264

rodcloutier · 2017-12-04T01:58:00Z

This PR intends to add full support for custom service cluster ip range.

Fixes #1536
Fixes #1747

Feel free to add some more requirements for testing.

minikube-bot · 2017-12-04T01:58:02Z

Can one of the admins verify this patch?

dlorenc · 2017-12-04T02:24:46Z

@minikube-bot ok to test

bacongobbler · 2018-01-25T17:04:16Z

pkg/minikube/cluster/cluster.go

@@ -173,7 +172,7 @@ func GetHostDriverIP(api libmachine.API) (net.IP, error) {
 func engineOptions(config MachineConfig) *engine.Options {
 	o := engine.Options{
 		Env:              config.DockerEnv,
-		InsecureRegistry: append([]string{pkgutil.DefaultServiceCIDR}, config.InsecureRegistry...),
+		InsecureRegistry: append([]string{config.ServiceCIDR}, config.InsecureRegistry...),


👍 glad this was picked up in the PR :)

fejta-bot · 2018-04-25T17:14:53Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

jar349 · 2018-04-25T17:36:01Z

/remove-lifecycle stale

I don't believe that this PR should close due to inactivity when it offers a point of configurability that would - at least to me - be useful. My use case is this: https://stevesloka.com/2017/05/19/access-minikube-services-from-host/

fejta-bot · 2018-07-24T18:33:52Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2018-08-23T19:20:36Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

jar349 · 2018-08-24T20:14:00Z

/remove-lifecycle rotten

jar349 · 2018-08-24T20:14:50Z

this one even includes a patch! it ain't rotten.

jar349 · 2018-08-24T20:17:04Z

@rodcloutier I wonder if it would be possible for you to freshen this up to make it super-simple for admins to approve?

dsiebel · 2018-09-05T08:16:59Z

I just built the minikube.iso image from this branch hoping it could fix my issues with colliding network ranges (company networks spanning 172.16/12 and 10.0/8) but sadly it didn't. The issue was with routing service IPs (10.96/12) within the cluster, which always went through my host and was terminated by our company firewall instead of going to the services I actually wanted.

I tried starting minikube with the following settings but it just stalls and aborts after 10 minutes or so:

minikube start --logtostderr --v=3 \
  --cpus 4 \
  --memory 4096 \
  --keep-context \
  --docker-opt="max-concurrent-downloads=8" \
  --docker-opt="bip=192.168.16.1/24" \
  --extra-config="apiserver.Authorization.Mode=RBAC" \
  --extra-config="apiserver.ServiceClusterIPRange=192.168.48.0/20" \
  --extra-config="kubelet.PodCIDR=192.168.32.0/20" \
  --extra-config="controller-manager.ClusterCIDR=192.168.32.0/20"

I also tried removing single CIDR parameters but the result didn't change.

In summary: not sure whether this PR actually fixes the issue but it would be really great if it did 😃

fejta-bot · 2018-12-04T09:10:24Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2019-01-03T09:55:22Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

tstromberg · 2019-01-16T00:48:14Z

Do you mind addressing the merge conflicts? I'd like to see about merging this if it's still viable. My apologies for the unnecessarily long delay in reviewing this PR.

tstromberg · 2019-02-08T23:39:01Z

Any hope for resurrecting this PR from the merge conflicts? I feel like it's doing the right thing and would love to see it in minikube. Thanks for all the hard work you've put into it so far.

rodcloutier · 2019-02-09T01:41:09Z

I will see what I can do.

…

On Feb 8, 2019, at 18:39, Thomas Strömberg ***@***.***> wrote: Any hope for resurrecting this PR from the merge conflicts? I feel like it's doing the right thing and would love to see it in minikube. Thanks for all the hard work you've put into it so far. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

k8s-ci-robot · 2019-02-18T23:10:35Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rodcloutier
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: luxas

If they are not already assigned, you can assign the PR to them by writing /assign @luxas in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…ster ip range

tstromberg · 2019-03-12T20:08:55Z

pkg/minikube/bootstrapper/kubeadm/kubeadm.go

@@ -294,15 +294,22 @@ func NewKubeletConfig(k8s config.KubernetesConfig, r cruntime.Manager) (string,
 		return "", errors.Wrap(err, "parses feature gate config for kubelet")
 	}

+	clusterDNS, err := util.GetDNSIP(k8s.ServiceCIDR)


Can you mention why the DNS changes are necessary in the PR comment?

tstromberg · 2019-03-12T20:10:12Z

pkg/minikube/config/types.go

@@ -43,6 +43,7 @@ type MachineConfig struct {
 	InsecureRegistry    []string
 	RegistryMirror      []string
 	HostOnlyCIDR        string // Only used by the virtualbox driver
+	ServiceCIDR         string // Use for insecure registry


I don't understand why the ServiceCIDR is only to be used with the insecure registry. Can you clarify this comment?

tstromberg · 2019-03-21T02:36:45Z

Thank you for the contribution. Due to recent inactivity and failing tests, I am marking this PR as closed until the issues can be resolved.

I really would like to see this PR come into being, so please re-open once it seems to be working. Before doing so, please run the integration tests locally: https://github.com/kubernetes/minikube/blob/master/docs/contributors/build_guide.md#integration-tests

Thank you again!

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 4, 2017

bacongobbler reviewed Jan 25, 2018

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 25, 2018

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 25, 2018

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 24, 2018

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 23, 2018

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 24, 2018

tstromberg mentioned this pull request Nov 7, 2018

none integration test: [ERROR Port-2379]: Port 2379 is in use #3312

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 4, 2018

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 3, 2019

rodcloutier force-pushed the serviceClusterIPRange branch from a2d844a to 80b67ac Compare February 18, 2019 23:10

k8s-ci-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 18, 2019

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 18, 2019

Proper support for kubelet cluster-dns option with custom service clu…

27b9943

…ster ip range

rodcloutier force-pushed the serviceClusterIPRange branch from 80b67ac to 27b9943 Compare February 19, 2019 11:43

tstromberg removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 12, 2019

tstromberg suggested changes Mar 12, 2019

View reviewed changes

tstromberg closed this Mar 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Full support for custom service cluster ip range #2264

Full support for custom service cluster ip range #2264

rodcloutier commented Dec 4, 2017 •

edited

Loading

minikube-bot commented Dec 4, 2017

dlorenc commented Dec 4, 2017

bacongobbler Jan 25, 2018

fejta-bot commented Apr 25, 2018

jar349 commented Apr 25, 2018

fejta-bot commented Jul 24, 2018

fejta-bot commented Aug 23, 2018

jar349 commented Aug 24, 2018

jar349 commented Aug 24, 2018

jar349 commented Aug 24, 2018

dsiebel commented Sep 5, 2018 •

edited

Loading

fejta-bot commented Dec 4, 2018

fejta-bot commented Jan 3, 2019

tstromberg commented Jan 16, 2019

tstromberg commented Feb 8, 2019

rodcloutier commented Feb 9, 2019 via email

k8s-ci-robot commented Feb 18, 2019

tstromberg Mar 12, 2019

tstromberg Mar 12, 2019

tstromberg commented Mar 21, 2019

Full support for custom service cluster ip range #2264

Full support for custom service cluster ip range #2264

Conversation

rodcloutier commented Dec 4, 2017 • edited Loading

minikube-bot commented Dec 4, 2017

dlorenc commented Dec 4, 2017

bacongobbler Jan 25, 2018

Choose a reason for hiding this comment

fejta-bot commented Apr 25, 2018

jar349 commented Apr 25, 2018

fejta-bot commented Jul 24, 2018

fejta-bot commented Aug 23, 2018

jar349 commented Aug 24, 2018

jar349 commented Aug 24, 2018

jar349 commented Aug 24, 2018

dsiebel commented Sep 5, 2018 • edited Loading

fejta-bot commented Dec 4, 2018

fejta-bot commented Jan 3, 2019

tstromberg commented Jan 16, 2019

tstromberg commented Feb 8, 2019

rodcloutier commented Feb 9, 2019 via email

k8s-ci-robot commented Feb 18, 2019

tstromberg Mar 12, 2019

Choose a reason for hiding this comment

tstromberg Mar 12, 2019

Choose a reason for hiding this comment

tstromberg commented Mar 21, 2019

rodcloutier commented Dec 4, 2017 •

edited

Loading

dsiebel commented Sep 5, 2018 •

edited

Loading