Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minikube support for k8s v1.15 #4412

Closed
wants to merge 43 commits into from
Closed

minikube support for k8s v1.15 #4412

wants to merge 43 commits into from

Conversation

fenglixa
Copy link
Contributor

@fenglixa fenglixa commented Jun 3, 2019

  1. minikube start for k8s v1.15, and check kubelet args:
    image

  2. minikube start for k8s v1.14.2, and check kubelet args:
    image

  • Build & Test PASS:
    image

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 3, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @fenglixa. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 3, 2019
@k8s-ci-robot k8s-ci-robot requested review from balopat and RA489 June 3, 2019 03:20
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 3, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

afbjorklund
afbjorklund reviewed Jun 3, 2019
View reviewed changes
pkg/minikube/bootstrapper/kubeadm/versions.go Outdated
Key: "allow-privileged",
Value: "true",
},
LessThanOrEqual: semver.MustParse("1.14.2"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed in 1.14.3 ? Maybe this should be < 1.15 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afbjorklund I checked change logs of v1.15.0-beta.1. The deprecated Kubelet flag --allow-privileged has been removed since v1.15.0-alpha.3. So here should change to <= 1.15.0-alpha.3.
Sorry for my mistake, and thanks for your reminder.

@afbjorklund
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2019
@afbjorklund afbjorklund added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2019
@afbjorklund
Copy link
Collaborator

We shouldn't merge this before 1.2.0 (that will have 1.14.3), and probably not before 1.15 is out properly.

@RA489
Copy link

RA489 commented Jun 4, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2019
medyagh and others added 3 commits June 4, 2019 09:25
@medyagh
fix mistake logic
7c8a0e2
@sharifelgamal
Merge pull request kubernetes#4383 from medyagh/4339
0151153 
Fix TestProxy
@k8s-ci-robot
Merge pull request kubernetes#4405 from fenglixa/fix-4367
d556d58 
Dashboard: add --disable-settings-authorizer to avoid settings 403 forbidden
sharifelgamal and others added 13 commits June 6, 2019 10:19
@sharifelgamal
Merge pull request kubernetes#4434 from medyagh/4433_filepath
53e8f9d 
Fixing file path for windows
@toabctl
Add libvirt and qemu-kvm install docs for openSUSE/SLES
34bd9be
@sharifelgamal
Merge pull request kubernetes#4443 from toabctl/opensuse-install-docs
70cdf33 
Add libvirt and qemu-kvm install docs for openSUSE/SLES
@sharifelgamal
Merge pull request kubernetes#4439 from afbjorklund/cache-none
80e200e 
Cache: don't use ssh runner for the none driver
@sharifelgamal
Upgrade to kubernetes 1.14.3
7119f57
@sharifelgamal
Merge pull request kubernetes#4431 from Pradip-Khakurel/issue-#4161-W…
dfd9b6b 
…antShowDriverDeprecationNotification-setting

fix ShowDriverDeprecationNotification config setting
@sharifelgamal
Merge pull request kubernetes#4444 from sharifelgamal/k8s-1.14.3
7d89ac1 
Upgrade to kubernetes 1.14.3
@sharifelgamal
Update Makefile for 1.1.1 release
9a7d0a0
@sharifelgamal
Update CHANGELOG for 1.1.1 release
993c86c
@sharifelgamal
Merge pull request kubernetes#4446 from sharifelgamal/1.1.1
ca886a6 
Update Makefile for 1.1.1 release
@sharifelgamal
Merge pull request kubernetes#4448 from sharifelgamal/1.1.1-release-n…
ef60a69 
…otes

Update CHANGELOG for 1.1.1 release
@minikube-bot
Update releases.json to include v1.1.1
8e4c6c9
@sharifelgamal
Merge pull request kubernetes#4449 from minikube-bot/jenkins-releases…
7d0c27a 
….json-v1.1.1

update releases.json to include v1.1.1
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fenglixa
To complete the pull request process, please assign ra489
You can assign the PR to them by writing /assign @ra489 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fenglixa added 2 commits June 11, 2019 15:38
@fenglixa
squash the commits
ff4e278 
minikube support for k8s v1.15

update case according to code changes

update to the minimum version of supporting --allow-privileged
@fenglixa
Merge branch 'support_k8s_v1.15' of https://github.com/fenglixa/minikube
dfbca14 
 into support_k8s_v1.15
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 11, 2019
@fenglixa
Copy link
Contributor Author

Sorry, squashed error, close this PR. I will create a new one later

@fenglixa fenglixa closed this Jun 11, 2019
@fenglixa fenglixa mentioned this pull request Jun 12, 2019
Merged
@fenglixa fenglixa mentioned this pull request Jun 26, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund afbjorklund left review comments

@balopat balopat Awaiting requested review from balopat

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.