Fix addons list output format option

[woodcockjosh]

Fixes option to set the output format for listing addons

[k8s-ci-robot]

Hi @woodcockjosh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[woodcockjosh]

/assign @medyagh

[medyagh]

I am not familiar with what this PR is trying to solve, do we have an issue for this ? or was it side effect of a recently merged PR ?

[woodcockjosh]

I am not familiar with what this PR is trying to solve, do we have an issue for this ? or was it side effect of a recently merged PR ?

@medyagh Apparently this feature doesn't work at all. I didn't open an issue because it was trivial to fix. However, there is a question about whether or not it should be implemented seeing as it doesn't work for anyone. Maybe instead we should implement a -o json like I did with the profile list rather than allowing user to specify a custom format. I can open an issue if you like?

[tstromberg]

Looks good. Do you mind adding a small integration test to make sure we don't break this in the future?

minikube/test/integration/functional_test.go

Line 307 in dcde5b6

func validateServicesCmd(ctx context.Context, t *testing.T, profile string) {

It's impossible to predict what addons are actually enabled until #4227 is resolved, but you can at least test something like "every line matches ^(en|dis)abled$`.

[tstromberg]

Since this may be your first integration test addition, I thought I'd point you to some useful docs for iterating quickly on integration tests:

https://github.com/kubernetes/minikube/blob/master/test/integration/README.md

[RA489]

/ok-to-test

[woodcockjosh]

@tstromberg I will have time to try to add a test tomorrow

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: woodcockjosh
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-io]

Codecov Report

Merging #5555 into master will increase coverage by 0.29%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #5555      +/-   ##
==========================================
+ Coverage   36.63%   36.93%   +0.29%     
==========================================
  Files         102      102              
  Lines        7346     7373      +27     
==========================================
+ Hits         2691     2723      +32     
+ Misses       4298     4297       -1     
+ Partials      357      353       -4

Impacted Files	Coverage Δ
cmd/minikube/cmd/config/addons_list.go	24.32% <100%> (+9.17%)	⬆️
cmd/minikube/cmd/start.go	22.63% <0%> (-0.03%)	⬇️
cmd/minikube/cmd/config/profile.go	0% <0%> (ø)	⬆️
cmd/minikube/cmd/version.go	0% <0%> (ø)	⬆️
cmd/minikube/cmd/update-check.go	0% <0%> (ø)	⬆️
pkg/minikube/bootstrapper/kubeadm/kubeadm.go	19.85% <0%> (+0.39%)	⬆️
pkg/minikube/out/out.go	57.89% <0%> (+0.75%)	⬆️
cmd/minikube/cmd/config/util.go	24.81% <0%> (+4.12%)	⬆️
pkg/minikube/notify/notify.go	89.23% <0%> (+23.07%)	⬆️

[woodcockjosh]

@medyagh this is complete

[woodcockjosh]

/retest

[sharifelgamal]

@minikube-bot OK to test

[tstromberg]

Thank you!