Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsutil: Remove trailing slashes, rsync instead of cp #5620

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

tstromberg
Copy link
Contributor

Fixes #5605

Test output:

$ gsutil -m rsync -dJ out gs://minikube-builds/mystery-test
Building synchronization state...
Starting synchronization...
Copying file://out/coverage.txt [Content-Type=text/plain]...
Copying file://out/minikube [Content-Type=application/octet-stream]...          
Copying file://out/minikube-linux-amd64 [Content-Type=application/octet-stream]...
Copying file://out/gvisor-addon [Content-Type=application/octet-stream]...
/ [4/4 files][137.6 MiB/137.6 MiB] 100% Done                                    
Operation completed over 4 objects/137.6 MiB.                                    

$ gsutil -m rsync -dJ out gs://minikube-builds/mystery-test
Building synchronization state...
Starting synchronization...

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 14, 2019
@tstromberg tstromberg requested a review from medyagh October 14, 2019 16:07
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2019
@codecov-io
Copy link

Codecov Report

Merging #5620 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5620   +/-   ##
=======================================
  Coverage   36.89%   36.89%           
=======================================
  Files         102      102           
  Lines        7369     7369           
=======================================
  Hits         2719     2719           
  Misses       4297     4297           
  Partials      353      353

@medyagh
Copy link
Member

medyagh commented Oct 14, 2019

@tstromberg while we are at it, do you mind adding this to the common.sh
to make sure we SEE that we are runnining the right commit ID

echo ">> Starting ${E2E_BIN} at $(date)"
echo ">> The minikube version & commit id:"
echo $(out/minikube-${OS_ARCH} version)

you can even go one step further and grep echo $(out/minikube-${OS_ARCH} version) for ${COMMIT} env var to see if it is the same with the one in Jenkins

@tstromberg
Copy link
Contributor Author

@tstromberg while we are at it, do you mind adding this to the common.sh
to make sure we SEE that we are runnining the right commit ID

echo ">> Starting ${E2E_BIN} at $(date)"
echo ">> The minikube version & commit id:"
echo $(out/minikube-${OS_ARCH} version)

you can even go one step further and grep echo $(out/minikube-${OS_ARCH} version) for ${COMMIT} env var to see if it is the same with the one in Jenkins

Will do so in a separate PR.

@tstromberg tstromberg merged commit 72698ef into kubernetes:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integration test: jenkins running the wrong binary but showing the right commit id
5 participants