Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable istio provisioner by default #6272

Closed
wants to merge 14 commits into from
Closed

disable istio provisioner by default #6272

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7a312a3
disable istio provisioner by default
medyagh Jan 10, 2020
9c4b9b7
revert unrelated change
medyagh Jan 10, 2020
391ebbe
remove unrelated chagne
medyagh Jan 10, 2020
cc937c0
Securing many http links to https links
Jan 13, 2020
1c6f256
Explicitly set LIBVIRT_DEFAULT_URI default for health checking
tstromberg Jan 10, 2020
817532b
Pass in the value of *kvmQemuURI for behavioral consistency
tstromberg Jan 11, 2020
ea890ab
Move away from go.mod when installing gopogh tool
afbjorklund Jan 13, 2020
f14d126
Fix some minor issues from gofmt and golint
afbjorklund Jan 13, 2020
99a326b
Handle empty k8s version in existing profile
afbjorklund Jan 13, 2020
b41f1d8
make minikube addons list tabular
medyagh Jan 10, 2020
72fce88
fix integration test for tabular view
medyagh Jan 11, 2020
ce446e3
fix integration test
medyagh Jan 13, 2020
4b71d32
add addons for kic
medyagh Jan 11, 2020
69680d3
fix typos
medyagh Jan 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions deploy/addons/istio/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
## istio Addon
[istio](https://istio.io/docs/setup/getting-started/) - Cloud platforms provide a wealth of benefits for the organizations that use them.

### Enabling istio
Propose to startup minikube with at least 8192 MB of memory and 4 CPUs to enable istio.
To enable this addon, simply run:
### Enable istio on minikube
Make sure to start minikube with at least 8192 MB of memory and 4 CPUs.

```shell script
minikube start --memory=8000mb --cpus=4
```

To enable this addon, simply run:
```shell script
minikube addons enable istio-proviioner
medyagh marked this conversation as resolved.
Show resolved Hide resolved
minikube addons enable istio
```

Expand All @@ -19,8 +24,9 @@ kubectl get po -n istio-system

If everything went well you shouldn't get any errors about istio being installed in your cluster. If you haven't deployed any releases `kubectl get po -n istio-system` won't return anything.

### Deprecation of istio
### Disable istio
To disable this addon, simply run:
```shell script
minikube addons disbale istio-proviioner
medyagh marked this conversation as resolved.
Show resolved Hide resolved
minikube addons disable istio
```
2 changes: 1 addition & 1 deletion pkg/minikube/assets/addons.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ var Addons = map[string]*Addon{
"istio-operator.yaml",
"0640",
true),
}, true, "istio-provisioner"),
}, false, "istio-provisioner"),
"istio": NewAddon([]*BinAsset{
MustBinAsset(
"deploy/addons/istio/istio-default-profile.yaml.tmpl",
Expand Down