Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid provision.Detector when possible #7244

Merged
merged 3 commits into from
Mar 26, 2020

Conversation

tstromberg
Copy link
Contributor

  • fixHost no longer attempts to re-provision BareMetal hosts, as doing so requires SSH. This fixes a regression: 'exit 0' : driver does not support ssh command
  • logRemoteOsRelease now uses the command-runner interface, so it is not necessary to call provision.DetectProvisioner

Fixes #4132 and #7190

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 26, 2020
@tstromberg tstromberg requested a review from medyagh March 26, 2020 00:15
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 26, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 26, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@codecov-io
Copy link

codecov-io commented Mar 26, 2020

Codecov Report

Merging #7244 into master will decrease coverage by 0.16%.
The diff coverage is 11.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7244      +/-   ##
==========================================
- Coverage   38.04%   37.87%   -0.17%     
==========================================
  Files         147      147              
  Lines        9087     9088       +1     
==========================================
- Hits         3457     3442      -15     
- Misses       5204     5221      +17     
+ Partials      426      425       -1     
Impacted Files Coverage Δ
pkg/minikube/machine/info.go 28.20% <0.00%> (+0.70%) ⬆️
pkg/minikube/machine/start.go 54.00% <0.00%> (ø)
pkg/minikube/machine/fix.go 39.07% <20.00%> (-1.87%) ⬇️
pkg/minikube/machine/machine.go 0.00% <0.00%> (-28.27%) ⬇️

@minikube-pr-bot
Copy link

All Times minikube: [ 67.233020 64.990033 64.712588]
All Times Minikube (PR 7244): [ 64.643093 70.139667 65.633976]

Average Minikube (PR 7244): 66.805579
Average minikube: 65.645214

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7244) |
+----------------------+-----------+--------------------+
| minikube v           |  0.155783 |           0.128372 |
| Creating kvm2        | 41.622335 |          43.071204 |
| Preparing Kubernetes | 21.718713 |          21.603935 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@tstromberg
Copy link
Contributor Author

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

none: reusing node: detecting provisioner: Too many retries waiting for SSH to be available
5 participants