Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dedicated SA for probes #2541

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Add a dedicated SA for probes #2541

merged 1 commit into from
Feb 8, 2024

Conversation

tosi3k
Copy link
Member

@tosi3k tosi3k commented Feb 8, 2024

For being able to launch probes before a default SA is created.

@tosi3k
Copy link
Member Author

tosi3k commented Feb 8, 2024

/hold

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2024
@tosi3k
Copy link
Member Author

tosi3k commented Feb 8, 2024

/retest
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2024
@tosi3k
Copy link
Member Author

tosi3k commented Feb 8, 2024

kubemark presubmit consistently fails with the following error:

docker build --pull -t gcr.io/k8s-infra-e2e-boskos-scale-25/kubemark:uhkblh .
ERROR: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
make: *** [Makefile:28: build] Error 1
Attempt 1 failed to make gcloudpush . Retrying.
docker build --pull -t gcr.io/k8s-infra-e2e-boskos-scale-25/kubemark:uhkblh .
ERROR: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
make: *** [Makefile:28: build] Error 1
Attempt 2 failed to make gcloudpush . Retrying.
docker build --pull -t gcr.io/k8s-infra-e2e-boskos-scale-25/kubemark:uhkblh .
ERROR: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
make: *** [Makefile:28: build] Error 1
Attempt 3 failed to make gcloudpush . Retrying.
�[0;31mFailed to make gcloudpush .

This started to fail just recently in kubemark CI jobs as well.

@k8s-ci-robot
Copy link
Contributor

@tosi3k: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-perf-tests-clusterloader2-kubemark 6b2238c link true /test pull-perf-tests-clusterloader2-kubemark

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tosi3k
Copy link
Member Author

tosi3k commented Feb 8, 2024

Opened kubernetes/test-infra#31889 for fixing Kubemark presubmit related to Docker-in-Docker.

@mborsz
Copy link
Member

mborsz commented Feb 8, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mborsz, tosi3k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mborsz mborsz merged commit 3d985c6 into kubernetes:master Feb 8, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants