Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go1.17] Build images for go1.17rc1 #2117

Merged
merged 1 commit into from
Jul 14, 2021
Merged

[go1.17] Build images for go1.17rc1 #2117

merged 1 commit into from
Jul 14, 2021

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Jun 10, 2021 •
edited
Loading

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

[go1.17] Build images for go1.17rc1
ref: https://kubernetes.slack.com/archives/C2C40FMNF/p1623342790278200

Which issue(s) this PR fixes:

Special notes for your reviewer:

/hold images are likely not available yet

Does this PR introduce a user-facing change?

[go1.17] Build images for go1.17rc1

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jun 10, 2021
@k8s-ci-robot k8s-ci-robot requested review from mkorbi and xmudrii June 10, 2021 16:57
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 10, 2021
@justaugustus
Copy link
Member Author

/retest

@justaugustus
Copy link
Member Author

/retest

@justaugustus: The following tests failed, say /retest to rerun all failed tests:
Test name Commit Details Rerun command
pull-release-image-kube-cross 59584b1 link /test pull-release-image-kube-cross
pull-release-image-go-runner 59584b1 link /test pull-release-image-go-runner

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Hmmmm, flake or...

/test pull-release-image-go-runner

@justaugustus
Copy link
Member Author

/test pull-release-image-go-runner

1 similar comment
@justaugustus
Copy link
Member Author

/test pull-release-image-go-runner

@justaugustus justaugustus mentioned this pull request Jun 16, 2021
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2021
@justaugustus
[go1.17] Build images for go1.17rc1
449303a 
Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2021
@justaugustus justaugustus changed the title [WIP][go1.17] Build canary images for go1.17beta1 [WIP][go1.17] Build images for go1.17rc1 Jul 14, 2021
@justaugustus justaugustus changed the title [WIP][go1.17] Build images for go1.17rc1 [go1.17] Build images for go1.17rc1 Jul 14, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 14, 2021
@justaugustus
Copy link
Member Author

/hold cancel
/assign @puerco @saschagrunert @cpanato

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 49ffc46 into kubernetes:master Jul 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 14, 2021
This was referenced Jul 14, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@mkorbi mkorbi Awaiting requested review from mkorbi

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@saschagrunert saschagrunert

@puerco puerco

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
5 participants
@justaugustus @k8s-ci-robot @saschagrunert @puerco @cpanato