Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Releases Notes Draft #547

Closed
wants to merge 1 commit into from
Closed

Updated Releases Notes Draft #547

wants to merge 1 commit into from

Conversation

dstrebel
Copy link
Contributor

Draft from working document

@dstrebel
Updated Releases Notes Draft
a8579b0 
Draft from working document
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 15, 2019
@k8s-ci-robot k8s-ci-robot requested review from amwat and jimangel March 15, 2019 10:40
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dstrebel
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: marpaia

If they are not already assigned, you can assign the PR to them by writing /assign @marpaia in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dstrebel
Copy link
Contributor Author

/assign @marpaia

marpaia
marpaia reviewed Mar 15, 2019
View reviewed changes
releases/release-1.14/release-notes-draft.md
## 1.14 What’s New


Support for Windows Nodes is Going GA (#116)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately all of these have to be #116 like:

[#116](https://github.com/kubernetes/enhancements/issues/116)

Or for k/k:

[#1234](https://github.com/kubernetes/kubernetes/issues/1234)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that and will correct it. Thanks @marpaia

@spiffxp
Copy link
Member

spiffxp commented Mar 26, 2019

/close
old draft at this point

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closed this PR.

In response to this:

/close
old draft at this point

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onyiny-ang onyiny-ang onyiny-ang left review comments

@marpaia marpaia marpaia left review comments

@amwat amwat Awaiting requested review from amwat

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@marpaia marpaia

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dstrebel @k8s-ci-robot @spiffxp @marpaia @onyiny-ang