Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and test Python without bazel #23830

Closed
chaodaiG opened this issue Sep 29, 2021 · 7 comments
Closed

Build and test Python without bazel #23830

chaodaiG opened this issue Sep 29, 2021 · 7 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@chaodaiG
Copy link
Contributor

chaodaiG commented Sep 29, 2021

What would you like to be added:

Build and test Python without bazel, the related bazel rules are:

  • py_binary
  • py_test

Things to be considered:

  • This will need to co-exist with current bazel rules for a short while, delete Python test targets from bazel once this confirmed working
  • Test driven by make rule and bash scripts
  • Ensure hermetic testing, including fixed tools version, like python, python3, dependencies
  • Test results are in junit results format

Why is this needed:

This is part of #23796

Recommended testing approach:

  • Make test invokable by make test
  • Create a PullRequest with change, manually run job by commenting /test pull-test-infra-test-beta
  • [Optional]: if there is any tool that needs to exist in test image, update image at
    - image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20211005-06df33eb71-test-infra

/sig testing
/help

@chaodaiG chaodaiG added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 29, 2021
@k8s-ci-robot
Copy link
Contributor

@chaodaiG:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

What would you like to be added:

Build and test Python without bazel, the related bazel rules are:

  • py_binary
  • py_test

Things to be considered:

  • This will need to co-exist with current bazel rules, we'll migrate everything over at once
  • Test driven by make rule and bash scripts
  • Ensure hermetic testing, including fixed tools version, like python, python3, dependencies
  • Test results are in junit results format

Why is this needed:

This is part of #23796

/sig testing
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 29, 2021
@khalludi
Copy link
Contributor

/assign

@chaodaiG
Copy link
Contributor Author

chaodaiG commented Dec 13, 2021

/assign

As mentioned in #24034, I will start working on this issue based on @khalludi 's effort

@BenTheElder
Copy link
Member

IMHO we should make this just py_test / py_lint, we don't need PAR or anything like that -- we will package things in docker images or not at all.

I think we already have py_test movement?

@chaodaiG
Copy link
Contributor Author

IMHO we should make this just py_test / py_lint, we don't need PAR or anything like that -- we will package things in docker images or not at all.

I think we already have py_test movement?

yeah we already have all of the py_test and py_lint working. it should be fine to mark this as done

@chaodaiG
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@chaodaiG: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants