Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cluster-API Provider DigitalOcean jobs #16802

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Update Cluster-API Provider DigitalOcean jobs #16802

merged 1 commit into from
Mar 16, 2020

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Mar 16, 2020

This PR updates jobs for Cluster-API Provider DigitalOcean, so kubernetes-sigs/cluster-api-provider-digitalocean#140 can be merged.

cc @prksu

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 16, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Mar 16, 2020

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Mar 16, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2020
@xmudrii xmudrii mentioned this pull request Mar 16, 2020
Merged
andrewsykim
andrewsykim reviewed Mar 16, 2020
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Mar 16, 2020

@andrewsykim Thank you for the review! This should be good to go.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0d0d9d4 into kubernetes:master Mar 16, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 16, 2020
@k8s-ci-robot
Copy link
Contributor

@xmudrii: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cluster-api-provider-digitalocean-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-digitalocean/cluster-api-provider-digitalocean-presubmits.yaml

In response to this:

This PR updates jobs for Cluster-API Provider DigitalOcean, so kubernetes-sigs/cluster-api-provider-digitalocean#140 can be merged.

cc @prksu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii xmudrii deleted the capi-do-jobs branch March 16, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@nikhita nikhita Awaiting requested review from nikhita

Assignees

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @k8s-ci-robot @andrewsykim