add multi-arch support to images/alpine #18189

lubinsz · 2020-07-07T07:01:36Z

2 test methods have been verified:
1, make -f images/alpine/Makefile
2, test command in prow job:
bazel-bin/images/builder/linux_amd64_stripped/builder --project==k8s-prow --allow-dirty=true images/alpine/

Currently, we are trying to enable arm64 prow ci for istio/kubevirt.
Both of the projects need the multi-arch images.

Signed-off-by: Bin Lu [email protected]

lubinsz · 2020-07-07T07:05:02Z

/assign @BenTheElder @fejta

lubinsz · 2020-07-07T07:11:15Z

Related issue: #16588

lubinsz · 2020-07-07T07:11:26Z

/cc @zhlhahaha

images/alpine/cloudbuild.yaml

fejta · 2020-07-07T21:01:33Z

images/alpine/cloudbuild.yaml

 substitutions:
  _GIT_TAG: '12345'
-images:
-  - 'gcr.io/$PROJECT_ID/alpine:$_GIT_TAG'


Please preserve the expected images to publish.

Hi,
In step 3, those images with fat-manifest will be pushed into registry with 'buildx --push' parameter .
I have tested the build methods(make & prowjob) with my private gcloud account, the multi-arch images can be pushed into my private gcloud registry automatically.

On the other hand, we can't load the multi-arch images into the local docker daemon with 'buildx --load' parameter .
Please see the issue as reference:
docker/buildx#59
If we keep this images field, the builder will report an error

Thanks, this is my first experience with buildx and multiarch images (thanks so much for working on this).

And if the push fails then the build fails? How about then adding a comment at the bottom about what images we expect this to push and why we don't use cloud build's auto verification?

And if the push fails then the build fails?

Yes.

How about then adding a comment at the bottom about what images we expect this to push and why we don't use cloud build's auto verification?

The comment has been added.

images/alpine/cloudbuild.yaml

fejta

/hold

for some optional comments, please remove when/if you address them. Thanks for this update!

lubinszARM · 2020-07-08T09:17:10Z

Hi @dims @BenTheElder
Any comments?
Thanks.

lubinszARM · 2020-07-08T09:17:29Z

/assign @dims

BenTheElder · 2020-07-09T22:28:42Z

images/alpine/cloudbuild.yaml

    - build
+    - --platform=linux/amd64,linux/arm64,linux/ppc64le


Any reason for this particular list of platforms?

Hi,
At present, kubevirt/istio is ready to do the prow ci for these 3 platforms: x86, powerpc, arm64.
And images/alpine is the basic image for other images, such as: git/sidecar/initupload...

Any reason for this particular list of platforms?

Hi, Ben,
We are trying to enable CI test for kubevirt/kubeflow/istio project on ARM. And facing a problem that in order to trigger a prow job on ARM cluster, prow utility images need to run on ARM cluster. So we are wandering if we can make at least these utility images (sidecar/initupload/entrypoint/clonerefs) support multi-arch. We have blocked here for really a long time.
Thanks a lot!

@BenTheElder
Any comments?

fejta · 2020-08-04T15:22:59Z

I'm inclined to merge this unless there are any outstanding issues?

srajmane · 2020-09-22T13:13:48Z

We are looking to add s390x support to the multiarch image. While this PR is yet to be merged,
@lubinsz could you please help in extending support for s390x as well through this PR by adding linux/s390x to --platform=linux/amd64,linux/arm64,linux/ppc64le?

lubinszARM · 2020-09-22T14:05:54Z

linux/s390x

OK.

Signed-off-by: Bin Lu <[email protected]>

k8s-ci-robot · 2020-09-23T02:53:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, lubinsz, zhlhahaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [fejta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fejta-bot · 2020-12-22T03:11:59Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

k8s-ci-robot · 2020-12-22T03:12:02Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

fejta-bot · 2021-01-21T03:56:29Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot · 2021-02-20T04:42:15Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

k8s-ci-robot · 2021-02-20T04:42:23Z

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/images sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 7, 2020

k8s-ci-robot requested review from chases2 and fejta July 7, 2020 07:02

k8s-ci-robot assigned BenTheElder and fejta Jul 7, 2020

k8s-ci-robot requested a review from zhlhahaha July 7, 2020 07:11

fejta reviewed Jul 7, 2020

View reviewed changes

lubinsz force-pushed the pr_images_arm64_1 branch from 90734fb to 689063c Compare July 8, 2020 02:58

fejta approved these changes Jul 8, 2020

View reviewed changes

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 8, 2020

lubinsz force-pushed the pr_images_arm64_1 branch from 689063c to eae2b21 Compare July 8, 2020 09:15

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2020

k8s-ci-robot assigned dims Jul 8, 2020

fejta approved these changes Jul 9, 2020

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2020

fejta mentioned this pull request Jul 9, 2020

Allow /approval variant for Prow approve plugin. #18141

Closed

BenTheElder reviewed Jul 9, 2020

View reviewed changes

chases2 removed their request for review July 15, 2020 23:56

zhlhahaha mentioned this pull request Jul 22, 2020

Enable Kubevirt works on ARM64 platform kubevirt/kubevirt#3415

Merged

dims removed their assignment Jul 26, 2020

add multi-arch support to images/alpine

d089921

Signed-off-by: Bin Lu <[email protected]>

lubinsz force-pushed the pr_images_arm64_1 branch from eae2b21 to d089921 Compare September 22, 2020 14:08

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2020

fejta approved these changes Sep 22, 2020

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2020

zhlhahaha approved these changes Sep 23, 2020

View reviewed changes

k8s-ci-robot assigned zhlhahaha Sep 23, 2020

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 22, 2020

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 22, 2020

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 21, 2021

k8s-ci-robot closed this Feb 20, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add multi-arch support to images/alpine #18189

add multi-arch support to images/alpine #18189

lubinsz commented Jul 7, 2020 •

edited

Loading

lubinsz commented Jul 7, 2020

lubinsz commented Jul 7, 2020

lubinsz commented Jul 7, 2020

fejta Jul 7, 2020

lubinsz Jul 8, 2020 •

edited

Loading

fejta Jul 8, 2020

lubinszARM Jul 8, 2020 •

edited

Loading

fejta left a comment

lubinszARM commented Jul 8, 2020

lubinszARM commented Jul 8, 2020

BenTheElder Jul 9, 2020

lubinsz Jul 10, 2020

zhlhahaha Jul 14, 2020

lubinszARM Jul 21, 2020

fejta commented Aug 4, 2020

srajmane commented Sep 22, 2020

lubinszARM commented Sep 22, 2020

k8s-ci-robot commented Sep 23, 2020

fejta-bot commented Dec 22, 2020

k8s-ci-robot commented Dec 22, 2020

fejta-bot commented Jan 21, 2021

fejta-bot commented Feb 20, 2021

k8s-ci-robot commented Feb 20, 2021

add multi-arch support to images/alpine #18189

add multi-arch support to images/alpine #18189

Conversation

lubinsz commented Jul 7, 2020 • edited Loading

lubinsz commented Jul 7, 2020

lubinsz commented Jul 7, 2020

lubinsz commented Jul 7, 2020

fejta Jul 7, 2020

Choose a reason for hiding this comment

lubinsz Jul 8, 2020 • edited Loading

Choose a reason for hiding this comment

fejta Jul 8, 2020

Choose a reason for hiding this comment

lubinszARM Jul 8, 2020 • edited Loading

Choose a reason for hiding this comment

fejta left a comment

Choose a reason for hiding this comment

lubinszARM commented Jul 8, 2020

lubinszARM commented Jul 8, 2020

BenTheElder Jul 9, 2020

Choose a reason for hiding this comment

lubinsz Jul 10, 2020

Choose a reason for hiding this comment

zhlhahaha Jul 14, 2020

Choose a reason for hiding this comment

lubinszARM Jul 21, 2020

Choose a reason for hiding this comment

fejta commented Aug 4, 2020

srajmane commented Sep 22, 2020

lubinszARM commented Sep 22, 2020

k8s-ci-robot commented Sep 23, 2020

fejta-bot commented Dec 22, 2020

k8s-ci-robot commented Dec 22, 2020

fejta-bot commented Jan 21, 2021

fejta-bot commented Feb 20, 2021

k8s-ci-robot commented Feb 20, 2021

lubinsz commented Jul 7, 2020 •

edited

Loading

lubinsz Jul 8, 2020 •

edited

Loading

lubinszARM Jul 8, 2020 •

edited

Loading