Updating the prowjob CRD to v1

[bradmwilliams]

The prowjob api has been available at v1 for quite some time. This PR bumps the existing CRDs from v1beta1 to v1.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @bradmwilliams!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @bradmwilliams. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alvaroaleman]

/cc @chaodaiG
At what kube version is the prow.k8s.io cluster? This need 1.16+ : https://www.openshift.com/blog/a-look-into-the-technical-details-of-kubernetes-1-16

🙃

[chaodaiG]

It's already 1.16+, all our prow instances as well, as prometheus operator wants 1.16+ too.
/cc @fejta
Who is oncall

[alvaroaleman]

/ok-to-test

[bradmwilliams]

I've signed the CLA

[bradmwilliams]

/retest

[alvaroaleman]

/retest

Weird, it fails waiting for sinker to delete the pod and prowjob, but sinker does that, according to the log

[bradmwilliams]

@alvaroaleman It appears that the issue is the pod is not getting flagged for deletion before the 60 second time limit expires.

[bradmwilliams]

/retest

[chaodaiG]

/hold
I would be concerned if the integration test passed with so many retries

[chaodaiG]

Trying to get you unblocked, sorry for being late here. I'm able to reproduce this locally, for some reason sinker is not cleaning the pods with your change, I'll take a deeper look to see what's going on.

What's weird is that sinker logs says it's deleting these pods, but nothing really happened

[chaodaiG]

There were several weird things happening in my local testing:

• Added a log at

  test-infra/prow/cmd/sinker/main.go

  Line 506 in 70fe663

  if k8serrors.IsNotFound(err) {

  , and it always returns k8serrors.IsNotFound(err) for all test cases, including running-pod, orphaned-pod etc.
• The prowjobs that were not found by sinker were discoverable by kubectl.

Compared prow jobs logs:

• The one failed in this PR: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/test-infra/21805/pull-test-infra-integration/1384245481613299712
• One passed in other PR: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/test-infra/21875/pull-test-infra-integration/1384681190530748416

And the sinker logs from the artifacts of the spyglass links above:

• https://gcsweb.k8s.io/gcs/kubernetes-jenkins/pr-logs/pull/test-infra/21875/pull-test-infra-integration/1384681190530748416/artifacts/prow_pod_logs/
• https://gcsweb.k8s.io/gcs/kubernetes-jenkins/pr-logs/pull/test-infra/21805/pull-test-infra-integration/1384245481613299712/artifacts/prow_pod_logs/

One noticeable difference is that this log line:

{"component":"sinker","file":"prow/cmd/sinker/main.go:324","func":"main.(*controller).clean","job":"","level":"info","msg":"Deleted prowjob.","name":"max-prow-job-age-0dfcc0aebfc0b5e6adb2e4aa72ed9eb8","severity":"info","time":"2021-04-21T01:41:20Z","type":""}

Only exists in the passed run but not in this PR, feels like sinker is not able to delete prowjob that exceeds max prow job age.

[fejta]

/uncc

[bradmwilliams]

/retest

[alvaroaleman]

/label tide/merge-method-squash
/hold cancel
Chao will need to approve though, I am not a root approver

[chaodaiG]

LGTM, would defer to @cjwagner who is oncall

[cjwagner]

LGTM as well, but I'll hold off on merging this until Monday in case we encounter unexpected issues.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, bradmwilliams, cjwagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• config/OWNERS [cjwagner]
• prow/OWNERS [alvaroaleman,cjwagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment