Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable workspace root importfor coverage lense #21897

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Apr 21, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/prow Issues or PRs related to prow area/prow/spyglass Issues or PRs related to prow's spyglass UI sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2021
@BenTheElder
Copy link
Member Author

needs testing, but theoretically this seems to bring back the previously relied upon behavior before we upgraded from 0.36 to 3.1

@BenTheElder
Copy link
Member Author

unable to verify this change currently due to bazelbuild/bazel#13379 + python (2.x) being removed from our workstations. i'll look into a workaround

@BenTheElder
Copy link
Member Author

BenTheElder commented Apr 21, 2021

curling spyglass/static/coverage/script_bundle.min.js contains the minified parseCoverage method exported by the imported parser module, whereas the one on prow.k8s.io has a literal import {parseCoverage} from "io_k8s_test_infra/gopherage/cmd/html/static/parser"; presumably that wasn't resolved at build time and won't work.

this should fix the issue.

edit: sudo apt-get install python-is-python3 for the workaround to get bazel running again.

@MushuEE
Copy link
Contributor

MushuEE commented Apr 21, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2021
@amwat
Copy link
Contributor

amwat commented Apr 21, 2021

/lgtm
/approve

was able to verify this locally

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amwat, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4e05630 into kubernetes:master Apr 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 21, 2021
@BenTheElder BenTheElder deleted the fix-node branch April 21, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/spyglass Issues or PRs related to prow's spyglass UI area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants