-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added prow job for depstat #22137
Merged
k8s-ci-robot
merged 12 commits into
kubernetes:master
from
RinkiyaKeDad:add_depstat_job
May 14, 2021
Merged
added prow job for depstat #22137
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
c81bf38
added prow job for depstat
RinkiyaKeDad 4425308
go get -> go install
RinkiyaKeDad f9c651a
working locally
RinkiyaKeDad 77628b0
fix shell errors
RinkiyaKeDad 04928e9
fix arg specifying method
RinkiyaKeDad 8a27d9b
removed '\' at the end
RinkiyaKeDad 0ae55e0
partly working locally
RinkiyaKeDad cfb6940
removed hardcoded
RinkiyaKeDad 5d4a6a7
major changes
RinkiyaKeDad 6b670bd
major changes 2
RinkiyaKeDad 70c516c
added annotations
RinkiyaKeDad abe925c
added new line
RinkiyaKeDad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
presubmits: | ||
kubernetes/kubernetes: | ||
- name: kubernetes-depstat | ||
decorate: true | ||
always_run: true | ||
skip_report: true | ||
spec: | ||
containers: | ||
- image: golang | ||
command: ["/bin/bash"] | ||
args: ["-c", "set -euo; | ||
BASE_SHA="${PULL_BASE_SHA:-""}"; ARTIFACTS="${ARTIFACTS:-/tmp/artifacts}"; | ||
mkdir -p "${ARTIFACTS}"; | ||
cd "$ARTIFACTS" | ||
go install github.com/kubernetes-sigs/depstat@latest; | ||
cd /go/src/k8s.io/kubernetes | ||
function write_report() { depstat stats --json; }; | ||
function diff_reports() { diff "$1" "$2"; }; | ||
write_report > "${ARTIFACTS}/stats.json"; | ||
if [ -n "${BASE_SHA}" ]; then | ||
git checkout -b base "${BASE_SHA}"; | ||
write_report > "${ARTIFACTS}/stats-base.json"; | ||
diff_reports "${ARTIFACTS}"/stats-base.json "${ARTIFACTS}"/stats.json; | ||
fi;"] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one of the tests is failing because it expects a
]
at the end of this line. So should I have the entire thing in one line to fix this? '-'@dims @spiffxp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the other pattern in general use : https://cs.k8s.io/?q=-%20%5C%7C&i=nope&files=&excludeFiles=&repos=kubernetes/test-infra